Fix AI Gateway package rename - #290
Merged
Merged
Conversation
mihaimitrea-db
marked this pull request as ready for review
August 5, 2026 15:42
parthban-db
approved these changes
Aug 5, 2026
parthban-db
left a comment
parthban-db
left a comment
Contributor
There was a problem hiding this comment.
Please confirm that the breaking changes are expected.
mihaimitrea-db
commented
Aug 6, 2026
Comment on lines
-376
to
-381
| const params = new URLSearchParams(); | ||
| if (req.includeBrowse !== undefined) { | ||
| params.append('include_browse', String(req.includeBrowse)); | ||
| } | ||
| const query = params.toString(); | ||
| const fullUrl = query !== '' ? `${url}?${query}` : url; |
Contributor
Author
There was a problem hiding this comment.
It seems that include_browse is marked as PUBLIC_UNDOCUMENTED.
mihaimitrea-db
commented
Aug 6, 2026
Comment on lines
-551
to
-555
| /** | ||
| * Whether the caller sees only metadata available through the BROWSE | ||
| * privilege. | ||
| */ | ||
| browseOnly?: boolean | undefined; |
Contributor
Author
There was a problem hiding this comment.
Same with browse_only.
Marked as PUBLIC_UNDOCUMENTED
mihaimitrea-db
commented
Aug 6, 2026
| * mirrors it to/from `aws_access_key`. Treated as username-equivalent (not a | ||
| * secret value): round-trips on reads and is scrubbed from audit logs. | ||
| */ | ||
| awsAccessKeyId?: string | undefined; |
Contributor
Author
There was a problem hiding this comment.
Marked as deprecated.
mihaimitrea-db
commented
Aug 6, 2026
| * handler mirrors it to/from `aws_access_key`. Supplied as inline plaintext | ||
| * via `ProviderSecret.plaintext`. | ||
| */ | ||
| awsSecretAccessKey?: ModelProviderServiceConfig_ProviderSecret | undefined; |
Contributor
Author
There was a problem hiding this comment.
Marked as deprecated.
…-rename # Conflicts: # packages/aigateway/NEXT_CHANGELOG.md # packages/aigateway/package.json # packages/uc/aigateway/CHANGELOG.md
mihaimitrea-db
force-pushed
the
fix/aigateway-package-rename
branch
from
August 6, 2026 10:43
4372699 to
a0eebd9
Compare
mihaimitrea-db
enabled auto-merge
August 6, 2026 10:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves AI Gateway from
@databricks/sdk-uc-aigatewayto@databricks/sdk-aigatewayand updates the generated package.Why
After the API package changed from
Uc.AiGatewaytoAiGateway, Phoenix removed the old generated source but left its workspace package. Formatting then failed because that package had no TypeScript files.What changed
packages/uc/aigatewaytopackages/aigateway.How is this tested?
npm run formatnpm run lintnpm run typechecknpm testnpm run test:browser