docs(#1458): fix FloatArrayCodec get_dtype example (<hash>, not <hash@>)#192
Merged
Conversation
The get_dtype example returned "<hash@>" for the store branch, but codecs return the base dtype "<hash>" — the framework composes the @ store modifier at declaration time. Matches built-in BlobCodec.get_dtype. Flagged by @MilagrosMarin in review of #188.
MilagrosMarin
approved these changes
Jul 1, 2026
MilagrosMarin
left a comment
MilagrosMarin
left a comment
Collaborator
There was a problem hiding this comment.
Verified. Matches BlobCodec.get_dtype on master (src/datajoint/builtin_codecs/blob.py: return "<hash>" if is_store else "bytes"). One-line fix for the exact concern I raised on #188. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #188.
The
FloatArrayCodec.get_dtypeexample inspark-adapter.mdreturned"<hash@>"for the store branch. Codecs return the base dtype"<hash>"— the framework composes the@store modifier at declaration time, not the codec. This matches the built-inBlobCodec.get_dtype, which returns"<hash>".Flagged by @MilagrosMarin in her review of #188 ("plugin authors copy-pasting the example may see divergent behavior").
Note: the two cosmetic residuals she also noted (stale
renderable.md/renderable-codecs.mdfilename table and the "stays draft" framing) lived in the #188 PR description, not in the merged files, so nothing to fix in-tree for those.