fix: skip rejected and dry-run requests in activity policies - #522
Merged
Merged
Conversation
Write rules now match only 2xx, non-dry-run requests, and guard request and response shapes so JSON Patch and Status bodies no longer error. Adds tests that mirror the activity processor.
scotwells
previously approved these changes
Oct 1, 2026
ecv
previously approved these changes
Oct 1, 2026
ecv
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activity policies recorded rejected requests and dry runs as real changes, and some rules errored on JSON Patch or
Statusbodies, sending events to the DLQ.?dryRun=.main.Replaying 30 days of production audits: 376 false activities removed, no successful request lost, no summary changed.