Skip to content

Latest downloadable nuget 1.0.24 does not match github #120

Description

@siggipop

I notice the nuget packaged contained some code that looked unfinished or different from github branch

From github master branch the Get method start like so:

public async Task<ResultType> Get<ResultType>(string entityCollection, string key, CRMGetListOptions QueryOptions = null)
{
    await CheckAuthToken();

    string fullUrl = string.Empty;
    if (key.Equals(Guid.Empty.ToString()) || String.IsNullOrEmpty(key))
        fullUrl = BuildGetUrl(entityCollection, QueryOptions);
    else
        fullUrl = BuildGetUrl(entityCollection + "(" + key + ")", QueryOptions);
    HttpRequestMessage request = new HttpRequestMessage(new HttpMethod("GET"), fullUrl);

But in the Nuget packet 1.0.24, the method starts like so:

public async Task<ResultType> Get<ResultType>(string entityCollection, string key, CRMGetListOptions QueryOptions = null)
{
   await CheckAuthToken();
   _ = string.Empty;
   HttpRequestMessage request = new HttpRequestMessage(requestUri: (!key.Equals(Guid.Empty.ToString()) && !string.IsNullOrEmpty(key)) ? BuildGetUrl(entityCollection + "(" + key + ")", QueryOptions) : BuildGetUrl(entityCollection, QueryOptions), method: new HttpMethod("GET"));
   if (QueryOptions?.FormattedValues ?? false)
   {
       request.Headers.Add("Prefer", "odata.include-annotations=\"OData.Community.Display.V1.FormattedValue\"");
   }

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions