V3 Work by dcarbone · Pull Request #48 · dcarbone/php-consul-api

dcarbone · 2025-04-11T01:42:01Z

Goals:

Copilot

Copilot reviewed 32 out of 51 changed files in this pull request and generated 2 comments.

Files not reviewed (19)

src/ACL/ACLAuthMethod.php: Language not supported
src/ACL/ACLAuthMethodListEntry.php: Language not supported
src/ACL/ACLAuthMethodListEntryQueryResponse.php: Language not supported
src/ACL/ACLAuthMethodNamespaceRule.php: Language not supported
src/ACL/ACLAuthMethodQueryResponse.php: Language not supported
src/ACL/ACLAuthMethodWriteResponse.php: Language not supported
src/ACL/ACLBindingRule.php: Language not supported
src/ACL/ACLBindingRuleQueryResponse.php: Language not supported
src/ACL/ACLBindingRuleWriteResponse.php: Language not supported
src/ACL/ACLBindingRulesQueryResponse.php: Language not supported
src/ACL/ACLClient.php: Language not supported
src/ACL/ACLEntriesResponse.php: Language not supported
src/ACL/ACLEntry.php: Language not supported
src/ACL/ACLLink.php: Language not supported
src/ACL/ACLLoginParams.php: Language not supported
src/ACL/ACLNodeIdentity.php: Language not supported
src/ACL/ACLOIDCAuthURLParams.php: Language not supported
src/ACL/ACLOIDCCallbackParams.php: Language not supported
src/ACL/ACLPolicy.php: Language not supported

Comments suppressed due to low confidence (1)

README.md:106

There appears to be an extra closing bracket in the client instantiation, which may lead to a syntax error in the example code. Consider removing the extra bracket.

$proxyClient = new \GuzzleHttp\Client(['proxy' => 'whatever proxy you want']]);

Copilot

Copilot reviewed 41 out of 60 changed files in this pull request and generated 1 comment.

Files not reviewed (19)

src/ACL/ACLAuthMethod.php: Language not supported
src/ACL/ACLAuthMethodListEntry.php: Language not supported
src/ACL/ACLAuthMethodListEntryQueryResponse.php: Language not supported
src/ACL/ACLAuthMethodNamespaceRule.php: Language not supported
src/ACL/ACLAuthMethodQueryResponse.php: Language not supported
src/ACL/ACLAuthMethodWriteResponse.php: Language not supported
src/ACL/ACLBindingRule.php: Language not supported
src/ACL/ACLBindingRuleQueryResponse.php: Language not supported
src/ACL/ACLBindingRuleWriteResponse.php: Language not supported
src/ACL/ACLBindingRulesQueryResponse.php: Language not supported
src/ACL/ACLClient.php: Language not supported
src/ACL/ACLEntriesResponse.php: Language not supported
src/ACL/ACLEntry.php: Language not supported
src/ACL/ACLLink.php: Language not supported
src/ACL/ACLLoginParams.php: Language not supported
src/ACL/ACLNodeIdentity.php: Language not supported
src/ACL/ACLOIDCAuthURLParams.php: Language not supported
src/ACL/ACLOIDCCallbackParams.php: Language not supported
src/ACL/ACLPolicy.php: Language not supported

Comments suppressed due to low confidence (1)

README.md:106

An extra closing bracket appears in the instantiation of \GuzzleHttp\Client, which may result in a syntax error. Please remove the additional bracket.

$proxyClient = new \GuzzleHttp\Client(['proxy' => 'whatever proxy you want']]);

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Daniel Carbone <daniel.p.carbone@gmail.com>

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

## Changes ### 1. ACL Token Methods (11 new methods) Added comprehensive ACL token update methods to AgentClient: - Legacy methods: UpdateACLToken, UpdateACLAgentToken, UpdateACLAgentMasterToken, UpdateACLReplicationToken - Modern methods (v1.4+): UpdateDefaultACLToken, UpdateAgentACLToken, UpdateAgentRecoveryACLToken, UpdateAgentMasterACLToken, UpdateReplicationACLToken, UpdateConfigFileRegistrationToken, UpdateDNSToken - Internal helper: updateToken(string $target, string $token, ?WriteOptions $opts) - All methods PUT to /v1/agent/token/{target} with JSON body ### 2. Connect Methods (3 new methods) - ConnectAuthorize(AgentAuthorizeParams): POST /v1/agent/connect/authorize - ConnectCARoots(?QueryOptions): GET /v1/agent/connect/ca/roots - ConnectCALeaf(string $serviceID, ?QueryOptions): GET /v1/agent/connect/ca/leaf/{serviceID} ### 3. New Response Types - AgentAuthorizeResponse: Wraps AgentAuthorize for ConnectAuthorize responses - ConnectCARootsResponse: Wraps CARootList with QueryMeta - ConnectCALeafResponse: Wraps LeafCert with QueryMeta ### 4. New Model Types - CARoot: Individual CA root certificate model with time parsing - CARootList: Collection of CA roots - LeafCert: Leaf certificate model with time parsing ### 5. QueryOptions Variants (13 new methods) Added *Opts variants supporting QueryOptions parameter: - ChecksWithFilterOpts, ServicesWithFilterOpts - AgentHealthServiceByIDOpts, AgentHealthServiceByNameOpts - ServiceDeregisterOpts, UpdateTTLOpts - CheckRegisterOpts, CheckDeregisterOpts - EnableServiceMaintenanceOpts, DisableServiceMaintenanceOpts - EnableNodeMaintenanceOpts, DisableNodeMaintenanceOpts - ForceLeaveOpts, ForceLeaveOptions (alias) ### 6. Version Method - Version(): Returns MapResponse with agent version information ### 7. MembersOpts Rename - Renamed MemberOpts class to MembersOpts with expanded features - Maintained backward compatibility via MemberOpts extends MembersOpts alias - MembersOpts() method added, MemberOpts() delegates to MembersOpts() ### 8. Comprehensive Testing - Added AgentClientTest.php with parameterized tests for all methods - Added unit tests for all new response types (AgentAuthorizeResponseTest, ConnectCARootsResponseTest, ConnectCALeafResponseTest) - Added unit tests for all new model types (CARootTest, CARootListTest, LeafCertTest) - Added MembersOptsTest to verify renamed class - Updated MemberOptsTest for backward compatibility - Updated integration tests to use new MembersOpts All tests pass: ✅ PHPUnit: 1252 tests, 5182 assertions ✅ PHPStan: No errors ✅ Psalm: No errors Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…hods This refactoring eliminates redundant *Opts method variants by consolidating them into single methods with optional QueryOptions parameters. This results in a cleaner, more intuitive API while maintaining full backward compatibility. REMOVED METHODS (13 total): - ChecksWithFilter, ChecksWithFilterOpts - ServicesWithFilter, ServicesWithFilterOpts - AgentHealthServiceByIDOpts - AgentHealthServiceByNameOpts - ServiceDeregisterOpts - UpdateTTLOpts - CheckRegisterOpts - CheckDeregisterOpts - EnableServiceMaintenanceOpts - DisableServiceMaintenanceOpts - EnableNodeMaintenanceOpts - DisableNodeMaintenanceOpts MODIFIED METHODS (12 total): - Checks(string $filter = '', ?QueryOptions $opts = null) - Services(string $filter = '', ?QueryOptions $opts = null) - AgentHealthServiceByID(string $id, ?QueryOptions $opts = null) - AgentHealthServiceByName(string $service, ?QueryOptions $opts = null) - ServiceDeregister(string $serviceID, ?QueryOptions $opts = null) - UpdateTTL(string $checkID, string $output, string $status, ?QueryOptions $opts = null) - CheckRegister(AgentCheckRegistration $check, ?QueryOptions $opts = null) - CheckDeregister(string $checkID, ?QueryOptions $opts = null) - EnableServiceMaintenance(string $serviceID, string $reason = '', ?QueryOptions $opts = null) - DisableServiceMaintenance(string $serviceID, ?QueryOptions $opts = null) - EnableNodeMaintenance(string $reason = '', ?QueryOptions $opts = null) - DisableNodeMaintenance(?QueryOptions $opts = null) OPTIMIZED METHODS: - ForceLeave now consolidates ForceLeave, ForceLeavePrune, ForceLeaveOpts, and ForceLeaveOptions into: ForceLeave(string $node, ?ForceLeaveOpts $opts = null, ?QueryOptions $qOpts = null) BENEFITS: - Reduced method count by ~30% - Eliminated code duplication - Cleaner, more intuitive API - No loss of functionality - Full backward compatibility for base method names CHANGES: - 129 lines removed from AgentClient.php (42 insertions, 171 deletions) - Updated unit tests to use consolidated methods - Updated integration tests to use new method signatures - All tests pass (211 unit tests, 0 failures) - PhpStan: OK (no errors) - Psalm: OK (no errors) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Created 16 comprehensive unit tests for KVClient covering all methods - Tests validate Get, List, Keys, Put, CAS, Acquire, Release, Delete, DeleteCAS, DeleteTree, and Txn methods - All tests pass with mock HTTP responses - Tests verify response types and state transitions - Total: 75 unit tests now pass for KV namespace Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

working on v3

cc0831e

dcarbone changed the title ~~working on v3~~ V3 Work Apr 11, 2025

dcarbone added 7 commits April 10, 2025 20:53

bit of readme update

480e352

readme

50e6268

allowing old map-style construction

c1b7373

small readme, may change...

97dfca7

lets be correct.

1a89930

reduce pointless line changes in PR.

9519d43

well that was dumb.

7a4f1c8

dcarbone requested a review from Copilot April 11, 2025 02:30

Copilot AI reviewed Apr 11, 2025

View reviewed changes

Comment thread README.md Outdated

Comment thread README.md Outdated

dcarbone added 4 commits April 10, 2025 22:04

removing trash, updating some base classes

f847aee

it can't be null

838eda5

Fine.

65e8e85

grammar

0301bec

dcarbone requested a review from Copilot April 11, 2025 03:12

Copilot AI reviewed Apr 11, 2025

View reviewed changes

Comment thread README.md Outdated

dcarbone and others added 10 commits April 10, 2025 22:13

dangit, the boy is right.

99f810d

thanx fren.

7b5bb04

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Daniel Carbone <daniel.p.carbone@gmail.com>

allow default in $data, starting work on Agent

279b0fb

oops

13784d3

lots of little work, long ways to go.

f53867c

lots more work, need to go back and fix some things.

6e11429

missed one

cbec949

maybe agent done?

af356ca

i dunno, sure.

f047f4c

ugh.

2554c66

dcarbone self-assigned this Apr 14, 2025

dcarbone added 2 commits April 14, 2025 19:56

ACL work.

4f1a05c

some cleanup

ec161b4

dcarbone added 6 commits April 15, 2026 21:22

ACL updates

0184373

stuff and also things

8854a90

moar

84bdd96

Merge remote-tracking branch 'origin/main' into dcarbone/v3

b9d4587

more stuff

df03d79

addressing some deprecations

88951ba

dcarbone requested a review from Copilot June 30, 2026 21:58

Copilot started reviewing on behalf of dcarbone June 30, 2026 21:58 View session

Copilot AI reviewed Jun 30, 2026

dcarbone added 13 commits July 1, 2026 20:41

some lil fixes

efdef95

some tests

438573c

prolly nothin

80a5452

stuff

d1cafff

better name

ef1aeca

merge

a44bec5

phpunit fix

4ad22f6

bump to minimum 8.2

b882d38

gitignore

ecafcd7

adding a buncha checks and stuff

da94236

php-cs-fixer

28e11c5

sure.

3e35b51

nope

bcf4938

dcarbone marked this pull request as ready for review July 5, 2026 03:51

dcarbone and others added 5 commits July 5, 2026 11:15

dates

1aa545b

cleanup

885ca78

dcarbone merged commit 6b14261 into main Jul 5, 2026
7 checks passed

dcarbone deleted the dcarbone/v3 branch July 5, 2026 18:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

V3 Work#48

V3 Work#48
dcarbone merged 140 commits into
mainfrom
dcarbone/v3

dcarbone commented Apr 11, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dcarbone commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goals:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dcarbone commented Apr 11, 2025 •

edited

Loading