Make RFQ quote issuance durable across restarts - #84
Closed
0xMuang wants to merge 1 commit into
Closed
Conversation
…d reorgs Constraint: RFQ service remains SDK/reference code without adding a production database dependency. Rejected: In-memory nonce and inventory reservation only | unsafe across server restart and multi-instance concurrency. Confidence: high Scope-risk: moderate Directive: Production deployment must supply an HA transactional database adapter and keep the bundled file store reference-only. Tested: npm RFQ, forge 857, RFQ E2E, diff, init race Not-tested: scripts/check fails pre-existing forge fmt in script/DeployProductionCore.s.sol and script/DemoScenarios.s.sol
This was referenced Aug 22, 2026
This was referenced Sep 3, 2026
Collaborator
Author
|
Superseded by consolidated delivery PR #89 after the author requested a reduced open-PR surface. This component branch and PR remain available as implementation and review history; no branch was deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
QuoteCoordinatorStore.Tests / validation
npm test --prefix services/rfq— passes locally in this integration step.git diff --cached --checkbefore commit — clean.contracts.md,deployments/, anddesc.mdpreserved and not staged.Known unrelated blocker
scripts/check.shis still blocked by pre-existingforge fmtdrift inscript/DeployProductionCore.s.solandscript/DemoScenarios.s.sol; this PR does not modify those files.Production boundary
(chainId, adapter, maker, nonce)and(chainId, adapter, maker, idempotencyKeyHash)constraints atomically.