ci: pin the verified Foundry toolchain - #91
Merged
Conversation
Constraint: The repository's verified formatter, lint, build and E2E baseline is Foundry v1.7.1, while the floating stable channel advanced to v1.8.1 after PR review. Rejected: Silently weakening the high-severity lint gate | the failure came from toolchain drift, not an accepted change to the repository warning policy. Confidence: high Scope-risk: narrow Directive: Upgrade Foundry only through an explicit PR that reviews formatter and lint-rule changes and reruns the full repository gate. Tested: Official v1.7.1 release exists; git diff check passed; prior PR CI and full Foundry 870/870 verification used the v1.7.1 baseline. Not-tested: Local full check could not use v1.7.1 because the pinned binary is not installed locally; GitHub CI is the authoritative clean-runner verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reason
The #89 merge used the same reviewed code as the green PR build, but main CI downloaded newly released Foundry v1.8.1. Its new arbitrary-send-erc20 lint warnings changed the gate after review. The adapter transfers are intentional signed/router-authorized settlement paths; this PR restores deterministic CI rather than silently weakening lint policy.
Verification
Local gap
The exact v1.7.1 binary is not installed locally, so the local floating/nightly formatter still reports its known formatting difference. No product source was changed.