fix: remove stale State entry from haystack.dataclasses lazy import structure#11621
Open
Kropiunig wants to merge 2 commits into
Open
fix: remove stale State entry from haystack.dataclasses lazy import structure#11621Kropiunig wants to merge 2 commits into
State entry from haystack.dataclasses lazy import structure#11621Kropiunig wants to merge 2 commits into
Conversation
|
@Kropiunig is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Contributor
|
Hey @Kropiunig thanks for the contribution! Please sign the CLA agreement #11621 (comment) otherwise we can't accept your contribution. |
Contributor
|
Hey @Kropiunig just checking in if you saw my previous comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #9578 removed the
statesubmodule (haystack/dataclasses/state.py) and itsTYPE_CHECKINGimport, but left the"state": ["State"]entry in the_import_structuredict that drives the lazy importer. As a resultStatestill appears indir(haystack.dataclasses), yetfrom haystack.dataclasses import StateraisesModuleNotFoundError: No module named 'haystack.dataclasses.state'. This removes the stale entry so the public namespace matches reality (the realStatenow lives inhaystack.components.agents).