Fix zero reduce bucket size validation - #8266
Open
fwerkor wants to merge 3 commits into
Open
Conversation
Signed-off-by: Cao Yuhang <caoyuhang@fwerkor.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
Author
|
Hi @tohtana, gentle ping — would appreciate a review when you have a chance. Thanks! |
sfc-gh-truwase
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject
zero_optimization.reduce_bucket_size=0during configuration validation instead of allowing ZeRO to fail later with a division by zero during backward.This changes the field constraint from non-negative to strictly positive and adds a boundary regression test covering
1as valid and0as invalid.Fixes #8260
Testing
python -m pytest tests/unit/runtime/zero/test_zero_config.py -q(7 passed)pre-commit run --files deepspeed/runtime/zero/config.py tests/unit/runtime/zero/test_zero_config.py