Fix misinformation about the need to quote IPv4 addresses - #93
Open
seifferth wants to merge 1 commit into
Open
Conversation
I used the DCLOGIN scheme today to debug an interoperability issue between Delta Chat for Android v2.53.0 and posteo.de. My experience was that `user@192.168.10.20` worked fine while `user@[192.168.10.20]` did not work at all. That's also what I would have expected anyway, since I have not yet seen IPv4 addresses enclosed in square brackets -- whereas for IPv6 it is indeed a very common practice.
iequidoo
approved these changes
Jul 14, 2026
iequidoo
left a comment
iequidoo
left a comment
Contributor
There was a problem hiding this comment.
The test in Chatmail Core should be fixed as well: https://github.com/chatmail/core/blob/94fc4f7550045544e3ae8c540582484785f61ec3/src/qr/dclogin_scheme.rs#L386-L389
The address in square brackets is parsed successfully there, but it it wouldn't actually work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used the DCLOGIN scheme today to debug an interoperability issue between Delta Chat for Android v2.53.0 and posteo.de. My experience was that
user@192.168.10.20worked fine whileuser@[192.168.10.20]did not work at all. That's also what I would have expected anyway, since I have not yet seen IPv4 addresses enclosed in square brackets -- whereas for IPv6 it is indeed a very common practice.