Conversation
Use Depot CI matrix position defaults when shard flags are omitted, while preserving explicit overrides and unsplit runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Verification
Note
Medium Risk
Changes when test splitting runs and how CI matrix jobs pick shards; mistakes in env or flag interaction could run the wrong subset of tests, though behavior without matrix env is largely unchanged.
Overview
depot tests runanddepot tests splitnow resolve--indexand--totalfromDEPOT_MATRIX_JOB_INDEXandDEPOT_MATRIX_JOB_TOTALwhen those flags are omitted, so matrix jobs can shard without repeating shard flags. Explicit flags still win; you can mix one flag with one env value.--total 1alone forces shard0/1, ignores matrix index, and keeps passthrough behavior (noSplitTests, candidates optional onrun).Split mode is only enabled when
total > 1(runSplitRequested), replacing the older rule that treated any shard-related flag as a split request. Matrix env values are validated (integer parsing, index/total must be set together, samevalidateShardrules as flags).Reviewed by Cursor Bugbot for commit 88f8591. Bugbot is set up for automated code reviews on this repo. Configure here.