Skip to content

feat(tests): rename run key flag#542

Merged
ischolten merged 2 commits into
mainfrom
report-key
Jul 15, 2026
Merged

feat(tests): rename run key flag#542
ischolten merged 2 commits into
mainfrom
report-key

Conversation

@ischolten

@ischolten ischolten commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • rename depot tests run --key to --report-key
  • keep --split-key independent and preserve depot tests report --key
  • clarify report-key descriptions and reject the legacy run flag

Note

Medium Risk
Breaking CLI rename for depot tests run will fail workflows still passing --key; scope is limited to flag naming and docs, not upload or split logic.

Overview
Renames the report invocation flag on depot tests run from --key to --report-key, with the internal option field renamed from key to reportKey. Upload behavior is unchanged: the value still flows into report upload as the invocation id, separate from --split-key.

depot tests report keeps --key; both commands now share the same help wording: the key is for distinguishing multiple report uploads in one CI run. Tests for run were updated to pass --report-key instead of --key.

Breaking: CI or scripts that still use depot tests run --key must switch to --report-key; there is no legacy alias in this change.

Reviewed by Cursor Bugbot for commit 060583f. Bugbot is set up for automated code reviews on this repo. Configure here.

@ischolten ischolten changed the title feat(tests): rename run key flag chore(tests): rename run key flag Jul 15, 2026
@ischolten ischolten changed the title chore(tests): rename run key flag feat(tests): rename run key flag Jul 15, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 147e634. Configure here.

Comment thread pkg/cmd/tests/run_test.go Outdated
cursor[bot]
cursor Bot approved these changes Jul 15, 2026
@ischolten
ischolten merged commit b3696d9 into main Jul 15, 2026
13 checks passed
@ischolten
ischolten deleted the report-key branch July 15, 2026 17:36

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: Cursor Bugbot and Cursor Security Agent both passed on the latest commit, and the prior Bugbot finding was resolved. No reviewers assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant