feat(tests): rename run key flag#542
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 147e634. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
depot tests run --keyto--report-key--split-keyindependent and preservedepot tests report --keyNote
Medium Risk
Breaking CLI rename for
depot tests runwill fail workflows still passing--key; scope is limited to flag naming and docs, not upload or split logic.Overview
Renames the report invocation flag on
depot tests runfrom--keyto--report-key, with the internal option field renamed fromkeytoreportKey. Upload behavior is unchanged: the value still flows into report upload as the invocation id, separate from--split-key.depot tests reportkeeps--key; both commands now share the same help wording: the key is for distinguishing multiple report uploads in one CI run. Tests forrunwere updated to pass--report-keyinstead of--key.Breaking: CI or scripts that still use
depot tests run --keymust switch to--report-key; there is no legacy alias in this change.Reviewed by Cursor Bugbot for commit 060583f. Bugbot is set up for automated code reviews on this repo. Configure here.