Skip to content

fix: expose s3-specific endpoint config - #760

Merged
kylebarron merged 2 commits into
developmentseed:mainfrom
Guflly:fix/s3-endpoint-override
Aug 21, 2026
Merged

fix: expose s3-specific endpoint config#760
kylebarron merged 2 commits into
developmentseed:mainfrom
Guflly:fix/s3-endpoint-override

Conversation

@Guflly

@Guflly Guflly commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #753.

This adds an s3_endpoint option so callers can explicitly override AWS_ENDPOINT_URL_S3. The alias round-trips through config and pickling, and the regression covers the environment precedence case.

Draft #755 touches the same config-key conversion code, so this may need a small rebase if it lands first.

Tests:

  • cargo test --all --all-features
  • cargo clippy on pyo3-object_store
  • Ruff and Pyright
  • endpoint regression against a local HTTP server

@ds-release-bot ds-release-bot Bot added the fix label Aug 3, 2026
Comment thread pyo3-object_store/src/aws/store.rs Outdated

@kylebarron kylebarron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kylebarron
kylebarron merged commit 039ab1a into developmentseed:main Aug 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS_ENDPOINT_URL_S3 silently overrides the explicit endpoint kwarg

2 participants