Skip to content

refactor(config): remove embedded default admin password #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nbmaiti wants to merge 1 commit into
base: pr/CM352
Choose a base branch
from
+4 −2
Draft

refactor(config): remove embedded default admin password #1238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/controller/tcp/cira/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,10 @@ func (h *APFHandler) validateCredentials(username, password string) bool {
return false
}

// Both comparisons always run so the response time does not reveal which
// field failed. MPSUsername is the field used for CIRA authentication.
// Both comparisons always run and the results are combined so the failing
// field is not revealed. subtle.ConstantTimeCompare is only constant time
// for equal-length inputs, so length differences remain observable.
// MPSUsername is the field used for CIRA authentication.
usernameMatches := subtle.ConstantTimeCompare([]byte(device.MPSUsername), []byte(username))
passwordMatches := subtle.ConstantTimeCompare([]byte(device.MPSPassword), []byte(password))

Expand Down
Loading