Fix: enable discussion and discussion_comment events in app manifest - #1
Open
m1lo9 wants to merge 1 commit into
Open
Fix: enable discussion and discussion_comment events in app manifest#1m1lo9 wants to merge 1 commit into
m1lo9 wants to merge 1 commit into
Conversation
Handlers for discussion badges (handleDiscussionAddBadge, handleDiscussionCommentAddBadge) were already implemented in src/handlers/badges.ts and registered in src/index.ts, but the corresponding events were commented out in app.yml, so the app never received these webhooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Handlers for discussion badges (
handleDiscussionAddBadge,handleDiscussionCommentAddBadge) were already implemented insrc/handlers/badges.tsand registered insrc/index.ts, but the corresponding events were commented out inapp.yml, so the app never received these webhooks.Fix
Uncommented the
discussionanddiscussion_commentevents inapp.ymlso they match the handlers that already exist in the codebase.Note for maintainer
This PR only updates the
app.ymlmanifest file, which serves as a reference/template — as noted in the file's own comment, changing it does not automatically update the live GitHub App configuration. To actually enable these handlers in production, please also manually enable thediscussionanddiscussion_commentevents under Settings → Permissions & events → Subscribe to Events on the app's settings page, then click Save changes.