Fix source-backed project reference matching - #150
Merged
Conversation
dfederm
force-pushed
the
dfederm/fix-referencetrimmer-149
branch
3 times, most recently
from
August 13, 2026 23:32
41c6e2f to
316e383
Compare
Preserve resolved project FusionName values in the declared-reference manifest and match RT0002 candidates by full Roslyn assembly identity while retaining path matching for existing reference kinds. Copilot-Session: fd367b4f-39d5-45fe-bd61-813ba71259e6
dfederm
force-pushed
the
dfederm/fix-referencetrimmer-149
branch
from
August 14, 2026 18:01
316e383 to
5ecfe1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #149, where RT0002 falsely reported used same-language project references as removable because Roslyn exposes them as source-backed
CompilationReferenceinstances rather than file-backed references. Matching now uses full assembly identity for source-backed references and file paths for PE-backed references.The declared-reference manifest adds an optional project fusion-name column while remaining compatible with existing three-column rows. RT0001 and RT0003 retain their existing path-based behavior.
Why this is safe
Validation
ubuntu-latestwindows-latestCloses #149