Inherit crossorigin on the injected web-vitals script#195
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
On pages that set Cross-Origin-Embedder-Policy: require-corp, the DAP tag can carry a crossorigin attribute so its response satisfies the policy. The dynamically injected web-vitals script never received that attribute, so it was blocked from loading on such pages. Read the crossorigin value from the DAP script tag (#_fed_an_ua_tag) and apply it to the web-vitals script element when present. Regenerated the minified bundle with the project's terser config. Fixes digital-analytics-program#167 Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #167.
On a page that sets
Cross-Origin-Embedder-Policy: require-corp, the DAP tag can be given acrossoriginattribute so its response satisfies the policy. That works forUniversal-Federated-Analytics-Min.jsitself, but the web-vitals script that the analytics code injects dynamically (web-vitals.attribution.iife.js) never received the attribute, so it was blocked from loading (screenshot in the issue).This reads the
crossoriginvalue from the DAP script tag (#_fed_an_ua_tag, already referenced elsewhere in the file) and applies it to the injected web-vitals<script>element when present. When the page does not setcrossorigin, nothing changes.Universal-Federated-Analytics.jsis the source; I regeneratedUniversal-Federated-Analytics-Min.js(and its map) with the repo's ownnpm run minify(terser +terser.config.json). Both files passnode --check.