fix(databases): preserve database firewall descriptions on append and remove (#1869) - #1923
Open
Kanika0306 wants to merge 1 commit into
Open
Kanika0306 wants to merge 1 commit into
Kanika0306 wants to merge 1 commit into
Conversation
… remove operations
Kanika0306
force-pushed
the
fix-db-firewall-description-loss
branch
from
August 24, 2026 19:18
2e36671 to
5dc7bd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1869: Database firewall rule descriptions were erased when appending or removing rules via
doctl databases firewalls appendordoctl databases firewalls remove.Cause
When reconstructing existing firewall rules prior to invoking
UpdateFirewallRules,doctlcopiedUUID,ClusterUUID,Type, andValue, but omittedDescription. Additionally, the vendoredgodo.DatabaseFirewallRulestruct was missing theDescriptionfield (json:"description,omitempty").Solution
Descriptionfield togodo.DatabaseFirewallRulein the vendoredgodopackage.DescriptioninRunDatabaseFirewallRulesAppend: CopiedfirewallRule.Description = rule.Descriptionduring rule reconstruction.DescriptioninRunDatabaseFirewallRulesRemove: CopiedDescription: rule.Descriptionduring rule reconstruction.DatabaseFirewallRulesdisplayer: AddedDescriptiontoCols(),ColMap(), andKV()so descriptions render in CLI output.TestDatabaseFirewallRulesAppendandTestDatabaseFirewallRulesRemoveto verify that existing firewall rule descriptions are preserved in the payload sent to DigitalOcean API.Verification
Ran unit tests:
go test -v ./commands -run TestDatabaseFirewallRules