remove DiscreteUniform factory method on Uniform. Fix Implementation - #170
Merged
Merged
Conversation
The Unifom distribution has a factory method that when 2 Ints are provided, creates a DiscreteUniform distribution instead of a Uniform distribution. This is confusing and also leads to unexpected behaviors when constructing uniform distributions. Therefore this constructor is removed. This commit also adds tests for the DiscreteUniform and fixes a bug in the implementation that was discovered when adding the tests.
benikm91
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Unifom distribution has a factory method that when 2 Ints are provided, creates a DiscreteUniform distribution instead of a Uniform distribution. This is confusing and also leads to unexpected behaviors when constructing uniform distributions. Therefore this constructor is removed.
This commit also adds tests for
DiscreteUniformand fixes a bug in the implementation that was discovered when adding the tests. It turns out thatjax.scipy.stats.randintdoes not exist and therefore cannot be used to compute thelogpmf. The solution is to simply compute the logprob ourselves, which is trivial for the discrete uniform distribution.