Repository navigation
Release v0.4.0 - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.4.0
What changed
de_shell/__init__.pybumped to0.4.0— the one place the version iswritten, and the value
publish.ymlrefuses to let a tag disagree withCHANGELOG.rstassembled from the fragments inupcoming_changes/Release notes (as they will appear in `CHANGELOG.rst`)
Review checklist
CHANGELOG.rstreads well — edit the assembled text directly if neededde_shell/__init__.pyworkflow runs for events raised with
GITHUB_TOKEN, so a PR opened by thisworkflow gets no
pull_requestrun. Close and reopen the PR, or push anempty commit to it, to get one. The wheel-contents leg is the one that
matters most: it fails if
de_shell/jsis missing, which is the wholepoint of the package.
Manual check CI cannot cover
CI never runs Electron — it typechecks the TypeScript and runs the node unit
tests, nothing more. Before tagging a release that touched the sidecar
protocol or
de_shell/js:python -m de_shell.jsprints the path)and run that app's e2e suite against it.
After merging
Tag the merge commit on main — the tag MUST be exactly
v0.4.0:The tag push triggers
publish.yml: it refuses a tag that does not matchde_shell.__version__, builds the distributions, checks the wheel carriesde_shell/js, and uploads to PyPI through trusted publishing.uv pip index versions de-shellshould list0.4.0.