Conversation
When a module is broken, print the path DKMS tried to check ($dkms_tree/<module>/<version>/source) instead of leaving the user to guess. Related: dkms-project#606, dkms-project#357, dkms-project#94
EndeavourOS uses the same Arch-style module layout, so it can share the existing 'arch' case.
After printing the missing path, suggest the two real options: remove the stale entry, or reinstall the source. The phrasing avoids 'clear this folder' to not encourage blind rm -rf on a system dir. Happy to drop this hint if maintainers prefer a terser message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR also adds
endeavourosto the distro case inrun_test.sh(a one-line, unrelated change). EndeavourOS uses the same Arch-style module layout, so it shares the existingarchcase. Happy to split it into a separate PR if preferred.What this does
When DKMS reports a module as
broken, the error message now shows thepath it tried to check, plus a short two-line hint about the next step.
Before:
After:
The hint deliberately avoids phrasing like "clear this folder", since that
could be read as an invitation to
rm -rfon a system directory. It namesboth real outcomes without being prescriptive.
Why
Diagnosing a broken DKMS module currently requires guessing which path is
missing and what to do about it. A real-world example is an nvidia-dkms
module left behind after a kernel update; the message gives no clue about
the source of the problem.
Changes
dkms.in: 4 call sites updated (module_is_broken_and_die,do_status,run_match,autoinstall).run_test.sh: expected output updated for all 10 broken-status testblocks, plus
endeavourosadded to the distro case (it uses the sameArch-style module layout, so tests can run there too).
Testing
./run_test.shpasses on EndeavourOS with kernel 7.2.7-zen1-1-zen:Notes
Happy to drop the two hint lines and keep just the path if maintainers
prefer a terser message. The hint is isolated in the same string
continuation in
dkms.in, so removing it is a two-line change.Fixes: #606
Related: #357, #94