build: report docker feature detection failures - #4082
Merged
Merged
Conversation
crazy-max
force-pushed
the
fix-docker-feature-detection
branch
from
September 16, 2026 13:30
fe2f340 to
269936e
Compare
crazy-max
marked this pull request as ready for review
September 16, 2026 13:46
Return daemon probe errors instead of treating them as unsupported features. Cache only successful results per docker context so failed or canceled probes can be retried. Probe the builder endpoint for the docker driver and the load destination for other drivers. Skip daemon detection for tarball exports, and cover retries, cancellation, concurrent lookups, and exporter probe selection. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-docker-feature-detection
branch
from
September 29, 2026 18:10
269936e to
56113fc
Compare
tonistiigi
approved these changes
Sep 30, 2026
tonistiigi
left a comment
Member
There was a problem hiding this comment.
Potential follow ups from agents:
- Docker driver feature detection (line 82) still caches a failed ListWorkers probe as unsupported. #4085 should address this before #3266 is considered fully resolved.
- The tests do not run concurrent feature lookups despite the commit’s coverage claim. The error fixtures in opt_test.go (line 88) and client_test.go (line 122) also contain invalid JSON.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix partially #3266
Return Docker feature detection errors instead of reporting unsupported manifest lists, and cache only successful results per Docker context so failed probes can be retried. Probe the builder daemon for the docker driver and the load destination for other drivers, while skipping daemon detection for tarball exports.
The driver-level
ListWorkersfeature cache has a similar error-handling issue and can be addressed in a follow-up:buildx/driver/docker/driver.go
Lines 83 to 103 in ddf35fc
Its
Featuresinterface cannot return errors, so simply allowing failed probes to retry could change capability results midway through a build. An early failure could disable default provenance, while a later successful probe allows the build to proceed without it. Fixing that safely requires propagating detection errors through the driver interface and its callers, which is broader than this targeted fix.