Skip to content

Add CODEOWNERS and document the code-owner merge gate - #507

Closed
chalin wants to merge 1 commit into
docsy:mainfrom
chalin:chalin-m24-codeowners-example-2026-0919
Closed

chalin wants to merge 1 commit into
docsy:mainfrom
chalin:chalin-m24-codeowners-example-2026-0919

Conversation

@chalin

@chalin chalin commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator
  • Scope: .github/CODEOWNERS naming @docsy/maintainers for every path, a maintainer-notes section stating the main merge rules, and the zizmor note's tense now that its code-scanning rule is live.
  • Out of scope: the ruleset change that requires code-owner review (a settings change, applied alongside this PR).
  • Why: parity with Add CODEOWNERS and document the code-owner merge gate docsy#2816: restoring "Allow GitHub Actions to create and approve pull requests" at the org would otherwise let a workflow's approval satisfy the 1-approval rule; requiring a code-owner review makes team membership the review boundary.

- Names the `docsy/maintainers` team as code owner for every path, so the `main` ruleset's code-owner review requirement makes team membership the review boundary (a workflow's approval never counts).
- States the merge rules in the maintainer notes; the code-scanning rule is now live, so "comes from".
@netlify

netlify Bot commented Sep 19, 2026

Copy link
Copy Markdown

Deploy Preview for goldydocs ready!

Name Link
🔨 Latest commit 271550c
🔍 Latest deploy log https://app.netlify.com/projects/goldydocs/deploys/6aae9a79e56cba000878bf2f
😎 Deploy Preview https://deploy-preview-507--goldydocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@chalin

chalin commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

Closing unmerged: the review-gate safeguard landed as the main ruleset's required-reviewers rule (team docsy/maintainers) instead of CODEOWNERS, so no file is needed; the maintainer-notes update follows in a docs-only PR.

@chalin chalin closed this Sep 19, 2026
@chalin
chalin deleted the chalin-m24-codeowners-example-2026-0919 branch September 19, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant