Conversation
|
|
SummaryCoverage spans clean builds, server startup and shutdown, basic database operations, prepared-query behavior, connection isolation and recovery, and stable text and binary data handling. It also exercises adversarial malformed-input cases, revealing unsafe error handling while normal application behavior remains healthy. Safe to merge — the failures identify medium-severity pre-existing defects in reset-state cleanup and malformed wire-input handling, but none are attributable to this dependency-only PR, with no regressions or newly introduced failures. These findings are suitable for follow-up rather than merge blockers. Tests run by ItoAdditional Findings DetailsThese findings are unrelated to the current changes but were observed during testing. 🟡 Reset leaves old prepared statements available
Evidence Package🟡 Malformed integer input triggers a server panic
Evidence Package🟡 Malformed array length triggers a server panic
Evidence PackageTip Reply with @itoqa to send us feedback on this test run. |
|
Diff SummaryBroad coverage exercised database function execution, argument dispatch, defaults, variadic and NULL handling, error recovery, session reset behavior, and malformed-input defenses. The tested behavior is broadly healthy across normal workflows, edge cases, and adversarial protocol inputs, with one existing limitation in named result columns for table-returning functions. Safe to merge — the only failure is a high-severity pre-existing behavior issue explicitly marked as unrelated to this PR, with no regressions or PR-attributable failures identified. The table-function limitation is a flag for later rather than a merge blocker for this change. Tests run by ItoAdditional Findings DetailsThese findings are unrelated to the current changes but were observed during testing. 🟠 Table functions hide named result columns
Evidence PackageTip Reply with @itoqa to send us feedback on this test run. |
Footnotes
|
|
Diff SummaryCoverage spans core function execution and result handling, including normal calls, argument ordering, defaults, numeric and array values, return types, set-returning results, and grouped operations. It also exercises edge and error paths such as NULL handling, invalid conversions, failed calls followed by retries, malformed variadic definitions, and connection recovery. Safe to merge — the only observed failure is an unrelated, pre-existing limitation in expanded SQL variadic calls and is not attributable to this PR; no regression or PR-caused failure was identified. The remaining coverage indicates low merge risk, with the unrelated variadic limitation best treated as a flag for later. Tests run by ItoAdditional Findings DetailsThese findings are unrelated to the current changes but were observed during testing. 🟡 Expanded SQL variadic calls cannot resolve
Evidence PackageTip Reply with @itoqa to send us feedback on this test run. |
Commit: SummaryCoverage spans core database expression behavior, including normal function and operator results, type conversion, return types, filtering, set-returning queries, and server recovery after errors. It also exercises edge cases involving nulls, invalid inputs, polymorphic values, and error propagation, with overall behavior healthy except for a crash-prone array operation. Merge with caution — the PR introduces a medium-severity server crash in a specific polymorphic array input path, making this an attributable reliability regression rather than a harmless test issue. The remaining exercised behavior is healthy, but the crash warrants a targeted fix before treating the change as fully safe. Tests run by ItoTip Reply with @itoqa to send us feedback on this test run. |


We can avoid memory allocations if we know the number of arguments we're going to process.