LEGO: Pull request from juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260906103242184 to main - #12695
Open
csigs wants to merge 1 commit into
Open
Conversation
csigs
requested review from
jonathanpeppers and
simonrozsival
as code owners
September 6, 2026 10:32
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR directly edits auto-generated non-English .lcl localization files (against repo conventions) and includes at least one localized error-message change that alters the original meaning.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates non-English localization .lcl resources for Xamarin.Android.Build.Tasks, adding new localized entries for recently introduced XA#### messages (e.g., XA4263, XA4325, XA4326) across multiple languages, and adjusts an existing Czech translation string.
Changes:
- Add localized resource entries for new XA#### messages in multiple
Localize/loc/**/Resources.resx.lclfiles. - Update Czech (cs) localization text for the XA1049 message.
File summaries
| File | Description |
|---|---|
| Localize/loc/zh-Hant/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new localized entries (XA4263, XA4325*, XA4326). |
| Localize/loc/zh-Hans/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new localized entries (XA4263, XA4325*, XA4326). |
| Localize/loc/tr/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new localized entries (XA4263, XA4325*, XA4326). |
| Localize/loc/ru/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new localized entries (XA4263, XA4325*, XA4326). |
| Localize/loc/pt-BR/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new localized entries (XA4263, XA4325*, XA4326). |
| Localize/loc/pl/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new localized entries (XA4263, XA4325*, XA4326). |
| Localize/loc/ja/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new localized entries (XA4263, XA4325*, XA4326). |
| Localize/loc/it/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new localized entries (XA4263, XA4325*, XA4326). |
| Localize/loc/fr/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new localized entries (XA4263, XA4325*, XA4326). |
| Localize/loc/es/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new localized entries (XA4263, XA4325*, XA4326). |
| Localize/loc/cs/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new localized entries and modifies the XA1049 Czech translation text. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Lite
| <Val><![CDATA[The 'AndroidEnableMarshalMethods' and 'PublishReadyToRun' MSBuild properties cannot both be set to 'true'. Set one property to 'false'.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Vlastnosti MSBuildu AndroidEnableMarshalMethods a PublishReadyToRun nelze současně nastavit na hodnotu true. Nastavte jednu vlastnost na false.]]></Val> | ||
| <Val><![CDATA[Vlastnosti MSBuildu AndroidEnableMarshalMethods a PublishReadyToRun nelze nastavit na hodnotu true. Nastavte jednu vlastnost na false.]]></Val> |
Comment on lines
+1647
to
+1651
| <Item ItemId=";XA4263" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true"> | ||
| <Str Cat="Text"> | ||
| <Val><![CDATA[The exported member '{0}' has unsupported signature type '{1}'. Use a Java peer type, a supported managed-to-Java mapping, or [ExportParameter]5D;.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[匯出的成員 '{0}' 具有不支援的簽章類型 '{1}'。請使用 Java 同儕型別、支援的 managed-to-Java 對應，或 [ExportParameter]5D;。]]></Val> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260906103242184 to main with localized lcls