LEGO: Pull request from juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260907103215126 to main - #12702
Open
csigs wants to merge 1 commit into
Open
Conversation
csigs
requested review from
jonathanpeppers and
simonrozsival
as code owners
September 7, 2026 10:32
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
It directly edits auto-generated Localize/loc/**.lcl files and introduces a corrupted English source string ([ExportParameter]5D;) that doesn’t match the canonical Resources.resx.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates localization (.resx.lcl) entries for Xamarin.Android.Build.Tasks in German (de) and Korean (ko), adding new resource strings for error/warning codes including XA4263, XA4325*, and XA4326.
Changes:
- Add new localized
.lclentries forXA4263indeandko. - Add new localized
.lclentries forXA4325,XA4325_AssemblyFailure,XA4325_SourceDestinationCount, andXA4326indeandko.
File summaries
| File | Description |
|---|---|
| Localize/loc/ko/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new Korean localization entries for XA4263, XA4325*, XA4326. |
| Localize/loc/de/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl | Adds new German localization entries for XA4263, XA4325*, XA4326. |
Review details
Suppressed comments (2)
Localize/loc/de/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl:1651
- ❌ error — The English
Valstring here appears corrupted:Resources.resxhas...or [ExportParameter].but this.lclentry has...or [ExportParameter]5D;.. This will produce incorrect/garbled output (and may break matching in localization tooling). Update the source string to match the canonical English resource text (and regenerate localized outputs).
<Val><![CDATA[The exported member '{0}' has unsupported signature type '{1}'. Use a Java peer type, a supported managed-to-Java mapping, or [ExportParameter]5D;.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Das exportierte Mitglied „{0}“ hat einen nicht unterstützten Signaturtyp „{1}“. Verwenden Sie einen Java-Peertyp, eine unterstützte Zuordnung von verwaltetem Code zu Java oder [ExportParameter]5D;.]]></Val>
Localize/loc/ko/src/Xamarin.Android.Build.Tasks/Properties/Resources.resx.lcl:1651
- ❌ error — The English
Valstring here appears corrupted:Resources.resxhas...or [ExportParameter].but this.lclentry has...or [ExportParameter]5D;. This will produce incorrect/garbled output. Update the canonical English resource (and regenerate localization outputs) so the.lclentry matches exactly.
<Val><![CDATA[The exported member '{0}' has unsupported signature type '{1}'. Use a Java peer type, a supported managed-to-Java mapping, or [ExportParameter]5D;.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[내보낸 멤버 '{0}'의 서명 형식 '{1}'은(는) 지원되지 않습니다. Java 피어 형식, 지원되는 관리형-대-Java 매핑 또는 [ExportParameter]5D;를 사용하세요.]]></Val>
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
Comment on lines
+1647
to
+1651
| <Item ItemId=";XA4263" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true"> | ||
| <Str Cat="Text"> | ||
| <Val><![CDATA[The exported member '{0}' has unsupported signature type '{1}'. Use a Java peer type, a supported managed-to-Java mapping, or [ExportParameter]5D;.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[Das exportierte Mitglied „{0}“ hat einen nicht unterstützten Signaturtyp „{1}“. Verwenden Sie einen Java-Peertyp, eine unterstützte Zuordnung von verwaltetem Code zu Java oder [ExportParameter]5D;.]]></Val> |
Comment on lines
+1647
to
+1651
| <Item ItemId=";XA4263" ItemType="0;.resx" PsrId="211" InstFlg="true" Leaf="true"> | ||
| <Str Cat="Text"> | ||
| <Val><![CDATA[The exported member '{0}' has unsupported signature type '{1}'. Use a Java peer type, a supported managed-to-Java mapping, or [ExportParameter]5D;.]]></Val> | ||
| <Tgt Cat="Text" Stat="Loc" Orig="New"> | ||
| <Val><![CDATA[내보낸 멤버 '{0}'의 서명 형식 '{1}'은(는) 지원되지 않습니다. Java 피어 형식, 지원되는 관리형-대-Java 매핑 또는 [ExportParameter]5D;를 사용하세요.]]></Val> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from juno/hb_6dddf33b-c6da-43d8-ac04-14d2c339cb00_20260907103215126 to main with localized lcls