Report cancelled SDK uninstalls accurately by GaTTGeng · Pull Request #2731 · dotnet/vscode-dotnet-runtime

GaTTGeng · 2026-06-19T01:40:44Z

Summary

preserve the failure reason returned by the global SDK uninstaller
recognize the @vscode/sudo-prompt UAC dismissal message as user cancellation
report a dismissed elevation prompt as a cancelled uninstall instead of suggesting that another install may be in progress
add regression coverage for the library failure propagation and the final language-model-facing message

Root cause

When the Windows UAC prompt was dismissed, @vscode/sudo-prompt returned
User did not grant permission.. The global uninstall worker discarded that
status and replaced it with an arbitrary error code and a fixed
Another install may be in progress message.

User impact

Copilot and other callers now receive an accurate cancellation message with
guidance to retry and accept the elevation prompt. Other uninstall failures
continue to use the existing generic guidance.

Validation

npm test in vscode-dotnet-runtime-library: 255 passing, 7 pending
npm run test:lm-tools in vscode-dotnet-runtime-extension: 68 passing

Fixes #2698

When a Windows user dismisses the UAC dialog during global SDK uninstall, @vscode/sudo-prompt surfaces "User did not grant permission." That string matched none of the existing tokens in isUserCancellationMessage, so the LLM tool path classified the cancellation as a generic failure and showed the wrong retry guidance. Broaden the regex to recognize it, and export the helper so the extension command path can reuse it (#2698).

uninstallGlobal previously discarded the installer's status string and returned the arbitrary code 117778 with a fixed "Another install may be in progress" message. When the user dismisses the UAC dialog the status already carries "User did not grant permission.", so propagate it into the DotnetUninstallFailed event and the return value instead. Add a unit test that stubs both global installers to assert the surfaced text (#2698).

The wrapper at the extension command path used to claim every non-zero uninstallGlobal result was "may have been cancelled, blocked by another install in progress, or require manual removal", and embedded the raw result inside "(code ...)". Now that uninstallGlobal forwards the elevation provider's reason string, detect the cancellation case via isUserCancellationMessage and emit a clear "admin/elevation prompt was dismissed" message; for non-numeric reasons drop the "code" wrapping since the result already reads as text (#2698).

Move uninstall failure formatting into a testable helper and verify that dismissing the elevation prompt is reported as a cancellation rather than an unrelated installer conflict. Fix #2698

GaTTGeng · 2026-06-19T01:43:10Z

@dotnet-policy-service agree

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

nagilson

Thank you for taking this on! You did a great job investigating. My feedback is mostly nitpicking and enhancements but happy to move this forward afterward and don't see any overall issues.

GaTTGeng · 2026-06-20T01:50:17Z

Thank you so much for the thorough review, @nagilson ! This is my first contribution to an open-source project, and receiving such detailed and constructive feedback genuinely means a lot to me. I'll work through each of your suggestions.

- Fix uninstallGlobal to emit DotnetUninstallSkipped and return '0' when other dependents remain instead of falling through to the failure path (Copilot) - Move buildUninstallFailureMessage into ErrorMessageUtilities.ts to avoid circular dependency between extension.ts and LanguageModelTools (nagilson) - Keep isUserCancellationMessage private in both modules (nagilson) - Trim result before numeric detection and use Number.isInteger instead of regex for readability (Copilot + nagilson) - Remove redundant failureDetails variable (nagilson) - Drop unnecessary VSCODE_DOTNET_RUNTIME_DISABLE_MUTEX env toggle in test (nagilson) - Parameterize prototype patching for Linux/WinMac installers to reduce duplication in regression test (nagilson)

GaTTGeng · 2026-06-22T00:55:12Z

Hi @nagilson, are there any areas where I need to improve? If so, please let me know. Thank u!

nagilson

Thank you for your kind words, you've done a great job for your first open-source PR especially! I appreciate the effort you put into applying the fixes. I have a remaining nitpick and once that is resolved this looks good to go.

Co-authored-by: Noah Gilson <OTAKUPENGUINOP@GMAIL.COM>

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Co-authored-by: Noah Gilson <OTAKUPENGUINOP@GMAIL.COM>

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

…tilities

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

GaTTGeng · 2026-06-24T05:09:48Z

Thank you for the kind words, and for the thorough review — it made the fix much better than what I started with. It's been a great experience contributing to this project!

mthalman

There should also be handling of 1602 cancellation for uninstallation within WinMacGlobalInstaller. This is already done today for installation but not uninstallation. See

vscode-dotnet-runtime/vscode-dotnet-runtime-library/src/Acquisition/WinMacGlobalInstaller.ts

Lines 196 to 203 in 7fb823b

    
           else if (installerResult === '1602') 
        
           { 
        
               // Special code for when user cancels the install 
        
               const err = new DotnetInstallCancelledByUserError(new EventCancellationError('DotnetInstallCancelledByUserError', 
        
                   `The install of .NET was cancelled by the user. Aborting.`), install); 
        
               this.acquisitionContext.eventStream.post(err); 
        
               throw err.error; 
        
           }

nagilson · 2026-07-21T20:19:39Z

There should also be handling of 1602 cancellation for uninstallation within WinMacGlobalInstaller. This is already done today for installation but not uninstallation. See

vscode-dotnet-runtime/vscode-dotnet-runtime-library/src/Acquisition/WinMacGlobalInstaller.ts

Lines 196 to 203 in 7fb823b

else if (installerResult === '1602')

{

// Special code for when user cancels the install

const err = new DotnetInstallCancelledByUserError(new EventCancellationError('DotnetInstallCancelledByUserError',

`The install of .NET was cancelled by the user. Aborting.`), install);

this.acquisitionContext.eventStream.post(err);

throw err.error;

}

Working on this. (For context for the contributor, we switched to a more stringent approval process so I can't approve your PR since I pushed to it last but I will get this through, you did your due diligence.)

This reverts commit 4b9dff9.

nagilson · 2026-07-21T20:47:11Z

@mthalman Great feedback on the status code handler; I've applied a fix.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

GaTTGeng added 4 commits June 19, 2026 09:35

Test cancelled uninstall message

cb4ff66

Move uninstall failure formatting into a testable helper and verify that dismissing the elevation prompt is reported as a cancellation rather than an unrelated installer conflict. Fix #2698

GaTTGeng changed the title ~~[codex] Report cancelled SDK uninstalls accurately~~ Report cancelled SDK uninstalls accurately Jun 19, 2026

GaTTGeng marked this pull request as ready for review June 19, 2026 01:55

Copilot AI review requested due to automatic review settings June 19, 2026 01:55

Copilot AI reviewed Jun 19, 2026

nagilson requested a review from Copilot June 19, 2026 22:27

Copilot started reviewing on behalf of nagilson June 19, 2026 22:27 View session

nagilson self-requested a review June 19, 2026 22:31

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread vscode-dotnet-runtime-library/src/Acquisition/DotnetCoreAcquisitionWorker.ts Outdated

Comment thread vscode-dotnet-runtime-extension/src/LanguageModelTools.ts Outdated

nagilson reviewed Jun 19, 2026

View reviewed changes

nagilson reviewed Jun 22, 2026

View reviewed changes

Comment thread vscode-dotnet-runtime-extension/src/ErrorMessageUtilities.ts Outdated

nagilson reviewed Jun 22, 2026

View reviewed changes

Comment thread vscode-dotnet-runtime-extension/src/ErrorMessageUtilities.ts Outdated

nagilson reviewed Jun 22, 2026

View reviewed changes

Comment thread vscode-dotnet-runtime-extension/src/LanguageModelTools.ts Outdated

Comment thread vscode-dotnet-runtime-library/src/Acquisition/DotnetCoreAcquisitionWorker.ts

Improve cancellation message wording

297f125

Co-authored-by: Noah Gilson <OTAKUPENGUINOP@GMAIL.COM>

Copilot AI review requested due to automatic review settings June 23, 2026 01:02

Copilot AI reviewed Jun 23, 2026

Remove unnecessary comma in uninstall failure message

912cdbc

Co-authored-by: Noah Gilson <OTAKUPENGUINOP@GMAIL.COM>

Copilot AI review requested due to automatic review settings June 23, 2026 01:03

Copilot AI reviewed Jun 23, 2026

Deduplicate isUserCancellationMessage by importing from ErrorMessageU…

afe9e6f

…tilities

Copilot AI review requested due to automatic review settings June 23, 2026 06:35

GaTTGeng force-pushed the fix/2698-surface-uninstall-error branch from c6cbdae to afe9e6f Compare June 23, 2026 06:35

Copilot AI reviewed Jun 23, 2026

Don't potentially include missing space . in error msg

3c80f3b

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 23, 2026 23:53

Copilot started reviewing on behalf of nagilson June 23, 2026 23:54 View session

nagilson approved these changes Jun 23, 2026

View reviewed changes

nagilson requested a review from a team June 23, 2026 23:54

Copilot AI reviewed Jun 23, 2026

View reviewed changes

Comment thread vscode-dotnet-runtime-extension/src/ErrorMessageUtilities.ts

Comment thread vscode-dotnet-runtime-extension/src/ErrorMessageUtilities.ts

Comment thread vscode-dotnet-runtime-library/src/Acquisition/DotnetCoreAcquisitionWorker.ts

nagilson requested a review from mthalman July 20, 2026 21:18

mthalman reviewed Jul 21, 2026

View reviewed changes

nagilson added 2 commits July 21, 2026 13:44

Handle cancellation errors on uninstall and install

e90f35d

please fix the code according to #2731 (review) this comment

4b9dff9

Copilot AI review requested due to automatic review settings July 21, 2026 20:44

Copilot started reviewing on behalf of nagilson July 21, 2026 20:45 View session

Revert "please fix the code according to #2731 (review) this comment"

c7c7e75

This reverts commit 4b9dff9.

nagilson requested a review from mthalman July 21, 2026 20:46

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Comment thread vscode-dotnet-runtime-library/src/EventStream/EventStreamEvents.ts

Comment thread vscode-dotnet-runtime-library/src/Acquisition/WinMacGlobalInstaller.ts

Copilot AI review requested due to automatic review settings July 21, 2026 20:48

Copilot AI reviewed Jul 21, 2026

mthalman approved these changes Jul 22, 2026

View reviewed changes

nagilson disabled auto-merge July 23, 2026 21:48

nagilson enabled auto-merge July 23, 2026 21:48

nagilson added this pull request to the merge queue Jul 23, 2026

github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 23, 2026

nagilson added this pull request to the merge queue Jul 23, 2026

github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 24, 2026

nagilson added this pull request to the merge queue Aug 4, 2026

github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 4, 2026

nagilson merged commit f75de5e into dotnet:main Aug 4, 2026
8 checks passed

	else if (installerResult === '1602')
	{
	// Special code for when user cancels the install
	const err = new DotnetInstallCancelledByUserError(new EventCancellationError('DotnetInstallCancelledByUserError',
	`The install of .NET was cancelled by the user. Aborting.`), install);
	this.acquisitionContext.eventStream.post(err);
	throw err.error;
	}

Uh oh!

Conversation

GaTTGeng commented Jun 19, 2026

Summary

Root cause

User impact

Validation

Uh oh!

GaTTGeng commented Jun 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

nagilson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GaTTGeng commented Jun 20, 2026

Uh oh!

GaTTGeng commented Jun 22, 2026

Uh oh!

Uh oh!

Uh oh!

nagilson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GaTTGeng commented Jun 24, 2026

Uh oh!

mthalman left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nagilson commented Jul 21, 2026

Uh oh!

nagilson commented Jul 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

mthalman left a comment •

edited

Loading