Bump tsconfig target/lib from es6 to es2022 - #2761
Merged
Merged
Conversation
The library and extensions set `target` and `lib` to `es6` (ES2015) in all tsconfig files. ES2015 predates `Array.prototype.includes` (ES2016), so the many `.includes()` calls across the codebase raised TS2550: "Property 'includes' does not exist on type 'string[]'. ... Try changing the 'lib' compiler option to 'es2016' or later." `lib`/`target` are compile-time only and are independent of the VS Code runtime. The extensions declare `engines.vscode: ^1.101.0`, and VS Code 1.101 runs on Node 22.15.1 (Electron 35.5.1), which fully supports ES2022. Newer VS Code builds ship even newer Node, so ES2022 is safe against the minimum supported host. Updated files: vscode-dotnet-runtime-library, vscode-dotnet-runtime-extension, vscode-dotnet-sdk-extension, sample, and tsconfig.eslint.json. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TypeScript compile-time configuration across the library, extensions, and sample to target ES2022, resolving TS2550 errors for newer JS APIs (e.g., Array.prototype.includes) while remaining compatible with the minimum supported VS Code engine (^1.101.0).
Changes:
- Bumped
compilerOptions.targetfromes6toes2022in all repo tsconfig files. - Bumped
compilerOptions.libfrom["es6"]to["es2022"]in all repo tsconfig files.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vscode-dotnet-sdk-extension/tsconfig.json | Targets ES2022 for SDK extension TypeScript compilation. |
| vscode-dotnet-runtime-library/tsconfig.json | Targets ES2022 for the shared acquisition library compilation. |
| vscode-dotnet-runtime-extension/tsconfig.json | Targets ES2022 for runtime extension TypeScript compilation. |
| tsconfig.eslint.json | Aligns ESLint TypeScript project settings with ES2022. |
| sample/tsconfig.json | Targets ES2022 for the sample extension compilation. |
lbussell
approved these changes
Jul 22, 2026
nagilson
added this pull request to the merge queue
Jul 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 24, 2026
nagilson
added this pull request to the merge queue
Aug 4, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library and extensions set
targetandlibtoes6(ES2015) in all tsconfig files. ES2015 predatesArray.prototype.includes(ES2016), so the many.includes()calls across the codebase raised TS2550: "Property 'includes' does not exist on type 'string[]'. ... Try changing the 'lib' compiler option to 'es2016' or later."lib/targetare compile-time only and are independent of the VS Code runtime. The extensions declareengines.vscode: ^1.101.0, and VS Code 1.101 runs on Node 22.15.1 (Electron 35.5.1), which fully supports ES2022. Newer VS Code builds ship even newer Node versions (https://github.com/ewanharris/vscode-versions), so ES2022 is safe against the minimum supported host.