Fixes issue #9807 REVIEW (2nd) AFTER #12486 merged DRAFT

Directory.Build.targets

@@ -3,9 +3,12 @@
   <Import Project="$(RepositoryEngineeringDir)Analyzer.targets" />
   <Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" />
   <Import Project="$(RepositoryEngineeringDir)packageContent.targets" />
-  <Import Project="$(RepositoryEngineeringDir)versioning.targets" />
   <Import Project="$(RepositoryEngineeringDir)Test.targets" Condition="'$(IsTestProject)' == 'true' "/>
 
+  <PropertyGroup>
+    <Description Condition="'$(Description)' == ''">$(AssemblyName)</Description>
+  </PropertyGroup>
+
   <!-- CA1416 Validate platform compatibility. Do not apply to netstandard as it does not have the attribute. -->
   <ItemGroup>
     <AssemblyAttribute Include="System.Runtime.Versioning.SupportedOSPlatform" Condition="!$(TargetFramework.StartsWith('netstandard'))">

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/WindowsFormsApplicationBase.vb

@@ -154,7 +154,8 @@ Namespace Microsoft.VisualBasic.ApplicationServices
             ' have our principal on the thread before that happens.
             If authenticationMode = AuthenticationMode.Windows Then
                 Try
-                    ' Consider: Sadly, a call to: System.Security.SecurityManager.IsGranted(New SecurityPermission(SecurityPermissionFlag.ControlPrincipal))
+                    ' Consider: Sadly, a call to:
+                    ' Security.SecurityManager.IsGranted(New SecurityPermission(SecurityPermissionFlag.ControlPrincipal))
                     ' Will only check the THIS caller so you'll always get TRUE.
                     ' What we need is a way to get to the value of this on a demand basis.
                     ' So I try/catch instead for now but would rather be able to IF my way around this block.
@@ -382,7 +383,8 @@ Namespace Microsoft.VisualBasic.ApplicationServices
 
                 _unhandledExceptionHandlers.Add(value)
 
-                ' Only add the listener once so we don't fire the UnHandledException event over and over for the same exception
+                ' Only add the listener once so we don't fire the
+                ' UnHandledException event over and over for the same exception
                 If _unhandledExceptionHandlers.Count = 1 Then
                     AddHandler Application.ThreadException, AddressOf OnUnhandledExceptionEventAdaptor
                 End If
@@ -631,7 +633,7 @@ Namespace Microsoft.VisualBasic.ApplicationServices
                 _formLoadWaiter = New AutoResetEvent(False)
 
                 Task.Run(Async Function() As Task
-                             Await _splashScreenCompletionSource.Task.ConfigureAwait(False)
+                             Await _splashScreenCompletionSource.Task.ConfigureAwait(continueOnCapturedContext:=False)
                              _formLoadWaiter.Set()
                          End Function)
 
@@ -653,7 +655,7 @@ Namespace Microsoft.VisualBasic.ApplicationServices
 
             If _splashTimer IsNot Nothing Then
 
-                'We only have a timer if there was a minimum timeout on the splash screen.
+                ' We only have a timer if there was a minimum timeout on the splash screen.
                 _splashTimer.Dispose()
                 _splashTimer = Nothing
             End If
@@ -725,7 +727,7 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         <SecuritySafeCritical()>
         Protected Sub HideSplashScreen()
 
-            'This ultimately wasn't necessary. I suppose we better keep it for backwards compatibility.
+            ' This ultimately wasn't necessary. I suppose we better keep it for backwards compatibility.
             SyncLock _splashLock
 
                 ' .NET Framework 4.0 (Dev10 #590587) - we now activate the main form before calling
@@ -766,7 +768,11 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         '''  variants was passed in.
         ''' </summary>
         ''' <param name="commandLineArgs"></param>
-        ''' <returns>Returning True indicates that we should continue on with the application Startup sequence.</returns>
+        ''' <returns>
+        '''  Returning <see langword="True">
+        '''   Indicates that we should continue on with the application Startup sequence.
+        '''  </see>
+        ''' </returns>
         ''' <remarks>
         '''  This extensibility point is exposed for people who want to override
         '''  the Startup sequence at the earliest possible point to
@@ -867,26 +873,29 @@ Namespace Microsoft.VisualBasic.ApplicationServices
                 End If
 
                 ' When we have a splash screen that hasn't timed out before the main form is ready to paint, we want to
-                ' block the main form from painting. To do that I let the form get past the Load() event and hold it until
-                ' the splash screen goes down. Then I let the main form continue it's startup sequence. The ordering of
-                ' Form startup events for reference is: Ctor(), Load Event, Layout event, Shown event, Activated event, Paint event.
+                ' block the main form from painting. To do that I let the form get past the Load() event and
+                ' hold it until the splash screen goes down. Then I let the main form continue it's startup sequence.
+                ' The ordering of Form startup events for reference is:
+                ' Ctor(), Load Event, Layout event, Shown event, Activated event, Paint event.
                 AddHandler MainForm.Load, AddressOf MainFormLoadingDone
             End If
 
             ' Run() eats all exceptions (unless running under the debugger). If the user wrote an
             ' UnhandledException handler we will hook the System.Windows.Forms.Application.ThreadException event
             ' (see Public Custom Event UnhandledException) which will raise our UnhandledException Event.
-            ' If our user didn't write an UnhandledException event, then we land in the try/catch handler for Forms.Application.Run().
+            ' If our user didn't write an UnhandledException event, then we land in the try/catch handler
+            ' for Forms.Application.Run().
             Try
                 Application.Run(_appContext)
             Finally
 
-                ' When Run() returns, the context we pushed in our ctor (which was a WindowsFormsSynchronizationContext)
-                ' is restored. But we are going to dispose it so we need to disconnect the network listener so that it
+                ' When Run() returns, the context we pushed in our ctor
+                ' (which was a WindowsFormsSynchronizationContext) is restored.
+                ' But we are going to dispose it so we need to disconnect the network listener so that it
                 ' can't fire any events in response to changing network availability conditions through a dead context.
                 If _networkObject IsNot Nothing Then _networkObject.DisconnectListener()
 
-                'Restore the prior sync context.
+                ' Restore the prior sync context.
                 AsyncOperationManager.SynchronizationContext = _appSynchronizationContext
                 _appSynchronizationContext = Nothing
             End Try
@@ -914,11 +923,12 @@ Namespace Microsoft.VisualBasic.ApplicationServices
             ' The timing is important because the network object has an AsyncOperationsManager in it that marshals
             ' the network changed event to the main thread. The asyncOperationsManager does a CreateOperation()
             ' which makes a copy of the executionContext. That execution context shows up on your thread during
-            ' the callback so I delay creating the network object (and consequently the capturing of the execution context)
-            ' until the principal has been set on the thread. This avoids the problem where My.User isn't set
-            ' during the NetworkAvailabilityChanged event. This problem would just extend itself to any future
-            ' callback that involved the asyncOperationsManager so this is where we need to create objects that
-            ' have a asyncOperationsContext in them.
+            ' the callback so I delay creating the network object
+            ' (and consequently the capturing of the execution context) until the principal has been set on the thread.
+            ' This avoids the problem where My.User isn't set during the NetworkAvailabilityChanged event.
+            ' This problem would just extend itself to any future callback that involved
+            ' the asyncOperationsManager so this is where we need to create objects that have
+            ' a asyncOperationsContext in them.
             If _turnOnNetworkListener And _networkObject Is Nothing Then
 
                 ' The is-nothing-check is to avoid hooking the object more than once.
@@ -956,7 +966,10 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         '''  that execution shouldn't continue.
         ''' </summary>
         ''' <param name="e"></param>
-        ''' <returns><see langword="True"/> indicates the exception event was raised / <see langword="False"/> it was not.</returns>
+        ''' <returns>
+        '''  <see langword="True"/> indicates the exception event was raised
+        '''  <see langword="False"/> it was not.
+        ''' </returns>
         <EditorBrowsable(EditorBrowsableState.Advanced)>
         Protected Overridable Function OnUnhandledException(e As UnhandledExceptionEventArgs) As Boolean
 
@@ -1050,7 +1063,10 @@ Namespace Microsoft.VisualBasic.ApplicationServices
                     Using pipeServer
                         Dim tokenSource As New CancellationTokenSource()
 #Disable Warning BC42358 ' Call is not awaited.
-                        WaitForClientConnectionsAsync(pipeServer, AddressOf OnStartupNextInstanceMarshallingAdaptor, cancellationToken:=tokenSource.Token)
+                        WaitForClientConnectionsAsync(
+                            pipeServer,
+                            AddressOf OnStartupNextInstanceMarshallingAdaptor,
+                            cancellationToken:=tokenSource.Token)
 #Enable Warning BC42358
                         DoApplicationModel()
                         tokenSource.Cancel()
@@ -1072,7 +1088,7 @@ Namespace Microsoft.VisualBasic.ApplicationServices
                         Throw New CantStartSingleInstanceException()
                     End Try
                 End If
-            End If 'Single-Instance application
+            End If ' Single-Instance application
         End Sub
 
     End Class

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Devices/ComputerInfo.vb

@@ -47,7 +47,6 @@ Namespace Microsoft.VisualBasic.Devices
         ''' <exception cref="ComponentModel.Win32Exception">
         '''  Throw if we are unable to obtain the memory status.
         ''' </exception>
-        <CLSCompliant(False)>
         Public ReadOnly Property AvailablePhysicalMemory() As UInt64
             Get
                 Return MemoryStatus.AvailablePhysicalMemory
@@ -64,7 +63,6 @@ Namespace Microsoft.VisualBasic.Devices
         ''' <exception cref="ComponentModel.Win32Exception">
         '''  Throw if we are unable to obtain the memory status.
         ''' </exception>
-        <CLSCompliant(False)>
         Public ReadOnly Property AvailableVirtualMemory() As UInt64
             Get
                 Return MemoryStatus.AvailableVirtualMemory
@@ -131,7 +129,6 @@ Namespace Microsoft.VisualBasic.Devices
         ''' <exception cref="ComponentModel.Win32Exception">
         '''  Throw if we are unable to obtain the memory status.
         ''' </exception>
-        <CLSCompliant(False)>
         Public ReadOnly Property TotalPhysicalMemory() As UInt64
             Get
                 Return MemoryStatus.TotalPhysicalMemory
@@ -148,7 +145,6 @@ Namespace Microsoft.VisualBasic.Devices
         ''' <exception cref="ComponentModel.Win32Exception">
         '''  Throw if we are unable to obtain the memory status.
         ''' </exception>
-        <CLSCompliant(False)>
         Public ReadOnly Property TotalVirtualMemory() As UInt64
             Get
                 Return MemoryStatus.TotalVirtualMemory