Fix issue #9807 Review AFTER PR ##11655

.github/policies/resourceManagement.yml

@@ -194,7 +194,7 @@ configuration:
               isRegex: False
       then:
       - addMilestone:
-          milestone: 9.0 Preview7
+          milestone: 9.0 RC1
       description: Apply milestone to PRs on the main branch
       triggerOnOwnActions: true
     - if:

.gitignore

@@ -385,3 +385,4 @@ InteropTests/NativeTests/out
 # 'git update-index --assume-unchanged <filename>' will allow ignoring changes for tracked files.
 **/ScratchProject/
 **/ScratchProjectWithInternals/
+/CodeMaid.config

Directory.Build.props

@@ -18,7 +18,11 @@
 
     <IsAnalyzerProject>false</IsAnalyzerProject>
     <IsAnalyzerProject Condition="!$(IsTestProject) and
-                                  ($(MSBuildProjectName.EndsWith('.Analyzers')) or $(MSBuildProjectName.EndsWith('.Analyzers.CSharp')))"
+                                  ($(MSBuildProjectName.EndsWith('.Analyzers')) 
+                                     or $(MSBuildProjectName.EndsWith('.CodeFixes.VisualBasic'))
+                                     or $(MSBuildProjectName.EndsWith('.CodeFixes.CSharp'))
+                                     or $(MSBuildProjectName.EndsWith('.Analyzers.VisualBasic'))
+                                     or $(MSBuildProjectName.EndsWith('.Analyzers.CSharp')))"
                                   >true</IsAnalyzerProject>
   </PropertyGroup>
 

Winforms.sln

@@ -177,6 +177,14 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TrimTestBinaryDeserializati
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "BinaryFormatTests", "src\System.Private.Windows.Core\tests\BinaryFormatTests\BinaryFormatTests.csproj", "{57EC5288-9513-46CF-8FB7-626199690D90}"
 EndProject
+Project("{778DAE3C-4631-46EA-AA77-85C1314464D9}") = "System.Windows.Forms.Analyzers.VisualBasic", "src\System.Windows.Forms.Analyzers.VisualBasic\src\System.Windows.Forms.Analyzers.VisualBasic.vbproj", "{FF211812-FCCC-4B6B-B536-C4D754195750}"
+EndProject
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "System.Windows.Forms.Analyzers.CodeFixes.CSharp", "src\System.Windows.Forms.Analyzers.CodeFixes.CSharp\System.Windows.Forms.Analyzers.CodeFixes.CSharp.csproj", "{1F836B14-D13D-42E0-BEAF-A821DD75DE49}"
+EndProject
+Project("{778DAE3C-4631-46EA-AA77-85C1314464D9}") = "System.Windows.Forms.Analyzers.CodeFixes.VisualBasic", "src\System.Windows.Forms.Analyzers.CodeFixes.VisualBasic\System.Windows.Forms.Analyzers.CodeFixes.VisualBasic.vbproj", "{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}"
+EndProject
+Project("{778DAE3C-4631-46EA-AA77-85C1314464D9}") = "System.Windows.Forms.Analyzers.VisualBasic.Tests", "src\System.Windows.Forms.Analyzers.VisualBasic\tests\UnitTests\System.Windows.Forms.Analyzers.VisualBasic.Tests\System.Windows.Forms.Analyzers.VisualBasic.Tests.vbproj", "{0FD53580-3175-4F8F-8372-BE46C9122EE0}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -981,6 +989,70 @@ Global
 		{57EC5288-9513-46CF-8FB7-626199690D90}.Release|x64.Build.0 = Release|Any CPU
 		{57EC5288-9513-46CF-8FB7-626199690D90}.Release|x86.ActiveCfg = Release|Any CPU
 		{57EC5288-9513-46CF-8FB7-626199690D90}.Release|x86.Build.0 = Release|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Debug|arm64.ActiveCfg = Debug|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Debug|arm64.Build.0 = Debug|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Debug|x64.ActiveCfg = Debug|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Debug|x64.Build.0 = Debug|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Debug|x86.ActiveCfg = Debug|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Debug|x86.Build.0 = Debug|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Release|Any CPU.Build.0 = Release|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Release|arm64.ActiveCfg = Release|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Release|arm64.Build.0 = Release|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Release|x64.ActiveCfg = Release|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Release|x64.Build.0 = Release|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Release|x86.ActiveCfg = Release|Any CPU
+		{FF211812-FCCC-4B6B-B536-C4D754195750}.Release|x86.Build.0 = Release|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Debug|arm64.ActiveCfg = Debug|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Debug|arm64.Build.0 = Debug|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Debug|x64.ActiveCfg = Debug|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Debug|x64.Build.0 = Debug|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Debug|x86.ActiveCfg = Debug|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Debug|x86.Build.0 = Debug|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Release|Any CPU.Build.0 = Release|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Release|arm64.ActiveCfg = Release|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Release|arm64.Build.0 = Release|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Release|x64.ActiveCfg = Release|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Release|x64.Build.0 = Release|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Release|x86.ActiveCfg = Release|Any CPU
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49}.Release|x86.Build.0 = Release|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Debug|arm64.ActiveCfg = Debug|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Debug|arm64.Build.0 = Debug|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Debug|x64.ActiveCfg = Debug|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Debug|x64.Build.0 = Debug|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Debug|x86.ActiveCfg = Debug|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Debug|x86.Build.0 = Debug|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Release|Any CPU.Build.0 = Release|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Release|arm64.ActiveCfg = Release|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Release|arm64.Build.0 = Release|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Release|x64.ActiveCfg = Release|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Release|x64.Build.0 = Release|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Release|x86.ActiveCfg = Release|Any CPU
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1}.Release|x86.Build.0 = Release|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Debug|arm64.ActiveCfg = Debug|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Debug|arm64.Build.0 = Debug|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Debug|x64.ActiveCfg = Debug|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Debug|x64.Build.0 = Debug|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Debug|x86.ActiveCfg = Debug|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Debug|x86.Build.0 = Debug|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Release|Any CPU.Build.0 = Release|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Release|arm64.ActiveCfg = Release|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Release|arm64.Build.0 = Release|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Release|x64.ActiveCfg = Release|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Release|x64.Build.0 = Release|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Release|x86.ActiveCfg = Release|Any CPU
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0}.Release|x86.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
@@ -1044,6 +1116,10 @@ Global
 		{55F3174F-C1FE-4C8F-AF71-2512630088F8} = {583F1292-AE8D-4511-B8D8-A81FE4642DDC}
 		{CFBCC732-C988-4FE7-A21B-98A142365374} = {680FB14C-7B0C-4D63-9F1A-18ACCDB0F52A}
 		{57EC5288-9513-46CF-8FB7-626199690D90} = {583F1292-AE8D-4511-B8D8-A81FE4642DDC}
+		{FF211812-FCCC-4B6B-B536-C4D754195750} = {E4C6C5F5-46E9-4C63-9628-26752B4D9C11}
+		{1F836B14-D13D-42E0-BEAF-A821DD75DE49} = {E4C6C5F5-46E9-4C63-9628-26752B4D9C11}
+		{C4C031D5-F79A-44B6-811E-0797E7D5C1C1} = {E4C6C5F5-46E9-4C63-9628-26752B4D9C11}
+		{0FD53580-3175-4F8F-8372-BE46C9122EE0} = {D3AD0BF9-F5E2-4913-9AE3-9C4998F95EA1}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {7B1B0433-F612-4E5A-BE7E-FCF5B9F6E136}

src/System.Windows.Forms.Analyzers/AppManifestAnalyzer.Help.md → docs/analyzers/AppManifestAnalyzer.Help.md

@@ -7,7 +7,7 @@ are automatically referenced for Window Forms .NET applications.
 
 `AppManifestAnalyzer` is automatically invoked when a Windows Forms application (`OutputType=Exe` or `OutputType=WinExe`) has a custom app.manifest.
 
-## [WFAC010](https://aka.ms/winforms-warnings/WFAC010): Unsupported high DPI configuration.
+## [WFO0003](https://aka.ms/winforms-warnings/WFAC010): Unsupported high DPI configuration.
 
 Windows Forms applications should specify application DPI-awareness via the [application configuration](https://aka.ms/applicationconfiguration) or
 [`Application.SetHighDpiMode` API](https://docs.microsoft.com/dotnet/api/system.windows.forms.application.sethighdpimode).

src/System.Windows.Forms.Analyzers.CSharp/ApplicationConfigurationGenerator.Help.md → docs/analyzers/ApplicationConfigurationGenerator.Help.md

@@ -19,7 +19,7 @@ public static void Initialize()
 For more information on application configuration refer to https://aka.ms/applicationconfiguration.
 
 
-## [WFAC001](https://aka.ms/winforms-warnings/WFAC001): Unsupported project type.
+## [WFO0001](https://aka.ms/winforms-warnings/WFAC001): Unsupported project type.
 
 Only projects with `OutputType` set to "Exe" or "WinExe" are supported, because only applications projects define an application entry point,
 where the application bootstrap code must reside.
@@ -33,7 +33,7 @@ where the application bootstrap code must reside.
 ---
 
 
-## [WFAC002](https://aka.ms/winforms-warnings/WFAC002): Unsupported property value.
+## [WFO0002](https://aka.ms/winforms-warnings/WFAC002): Unsupported property value.
 
 The specified project property cannot be set to the given value.
 

docs/analyzers/Experimental.Help.md

@@ -0,0 +1,10 @@
+# List of WinForms Experimental Function Areas
+
+System.Windows.Forms.Analyzers analyzers and source generators are shipped inbox with Windows Desktop .NET SDK, and
+are automatically referenced for Window Forms .NET applications.
+
+| Diagnostic ID  | Description |
+| :------------- | :---------- |
+|  __`WFO5000`__ | Functionality around Visual Styling is experimental in .NET 9. |
+|  __`WFO5001`__ | Functionality around Dark Mode Colors is experimental in .NET 9. |
+|  __`WFO5002`__ | New ASync APIs for e.g. consuming Windows projected APIs, WebView2 or AI/LLM Libs are experimental in .NET 9. |

docs/analyzers/WinFormsCSharpAnalyzers.Help.md

@@ -0,0 +1,39 @@
+# How to use System.Windows.Forms.Analyzers
+
+System.Windows.Forms.Analyzers analyzers and source generators are shipped inbox with Windows Desktop .NET SDK, and
+are automatically referenced for Window Forms .NET applications.
+
+## `AppManifestAnalyzer`
+
+`AppManifestAnalyzer` is automatically invoked when a Windows Forms application (`OutputType=Exe` or `OutputType=WinExe`) has a custom app.manifest.
+
+### [WFO0003](https://aka.ms/winforms-warnings/WFAC010): Unsupported high DPI configuration.
+
+Windows Forms applications should specify application DPI-awareness via the [application configuration](https://aka.ms/applicationconfiguration) or
+[`Application.SetHighDpiMode` API](https://docs.microsoft.com/dotnet/api/system.windows.forms.application.sethighdpimode).
+
+|Item|Value|
+|-|-|
+| Category | ApplicationConfiguration |
+| Enabled | True |
+| Severity | Warning |
+| CodeFix | False |
+---
+
+## `MissingPropertySerializationConfiguration`
+
+`MissingPropertySerializationConfiguration` checks for missing `DesignerSerializationVisibilityAttribute` on properties of classes which are 
+derived from `Control` and could potentially serialize design-time data by the designer without the user being aware of it.
+
+### [WFO1000](https://aka.ms/winforms-warnings/WFO1000): Missing property serialization configuration.
+
+Properties of classes derived from `Control` should have `DesignerSerializationVisibilityAttribute` 
+set to `DesignerSerializationVisibility.Content` or `DesignerSerializationVisibility.Visible`.
+
+|Item|Value|
+|-|-|
+| Category | ApplicationConfiguration |
+| Enabled | True |
+| Severity | Warning |
+| CodeFix | False |
+---

docs/analyzers/WinFormsVisualBasicAnalyzers.Help.md

@@ -0,0 +1,39 @@
+# How to use System.Windows.Forms.Analyzers
+
+System.Windows.Forms.Analyzers analyzers and source generators are shipped inbox with Windows Desktop .NET SDK, and
+are automatically referenced for Window Forms .NET applications.
+
+## `AppManifestAnalyzer`
+
+`AppManifestAnalyzer` is automatically invoked when a Windows Forms application (`OutputType=Exe` or `OutputType=WinExe`) has a custom app.manifest.
+
+### [WFO0003](https://aka.ms/winforms-warnings/WFAC010): Unsupported high DPI configuration.
+
+Windows Forms applications should specify application DPI-awareness via the [application configuration](https://aka.ms/applicationconfiguration) or
+[`Application.SetHighDpiMode` API](https://docs.microsoft.com/dotnet/api/system.windows.forms.application.sethighdpimode).
+
+|Item|Value|
+|-|-|
+| Category | ApplicationConfiguration |
+| Enabled | True |
+| Severity | Warning |
+| CodeFix | False |
+---
+
+## `MissingPropertySerializationConfiguration`
+
+`MissingPropertySerializationConfiguration` checks for missing `DesignerSerializationVisibilityAttribute` on properties of classes which are 
+derived from `Control` and could potentially serialize design-time data by the designer without the user being aware of it.
+
+### [WFO1000](https://aka.ms/winforms-warnings/WFO1000): Missing property serialization configuration.
+
+Properties of classes derived from `Control` should have `DesignerSerializationVisibilityAttribute` 
+set to `DesignerSerializationVisibility.Content` or `DesignerSerializationVisibility.Visible`.
+
+|Item|Value|
+|-|-|
+| Category | ApplicationConfiguration |
+| Enabled | True |
+| Severity | Warning |
+| CodeFix | False |
+---

docs/analyzers/akams.txt

@@ -0,0 +1,7 @@
+https://aka.ms/WfoGenManifest		https://github.com/dotnet/winforms/blob/main/src/System.Windows.Forms.Analyzers/AppManifestAnalyzer.Help.md
+https://aka.ms/WfoExperimental		https://github.com/dotnet/winforms/blob/main/src/System.Windows.Forms.Analyzers/Experimental.Help.md
+
+https://aka.ms/WfoCsAppConfig		https://github.com/dotnet/winforms/blob/main/src/System.Windows.Forms.Analyzers.CSharp/ApplicationConfigurationGenerator.Help.md
+https://aka.ms/WfoCsAnalyzers		https://github.com/dotnet/winforms/blob/main/src/System.Windows.Forms.Analyzers.CSharp/WinFormsCSharpAnalyzers.Help.md
+
+https://aka.ms/WfoVbAnalyzers		https://github.com/dotnet/winforms/blob/main/src/System.Windows.Forms.Analyzers.VisualBasic/WinFormsVisualBasicAnalyzers.Help.md

eng/Localize/LocProject.json

@@ -112,11 +112,26 @@
                                               "CopyOption":  "LangIDOnName",
                                               "OutputPath":  ".\\src\\System.Windows.Forms.Analyzers\\src\\Resources\\xlf\\"
                                           },
+                                          {
+                                              "SourceFile":  ".\\src\\System.Windows.Forms.Analyzers.CodeFixes.CSharp\\Resources\\xlf\\SR.xlf",
+                                              "CopyOption":  "LangIDOnName",
+                                              "OutputPath":  ".\\src\\System.Windows.Forms.Analyzers.CodeFixes.CSharp\\Resources\\xlf\\"
+                                          },
+                                          {
+                                              "SourceFile":  ".\\src\\System.Windows.Forms.Analyzers.CodeFixes.VisualBasic\\Resources\\xlf\\SR.xlf",
+                                              "CopyOption":  "LangIDOnName",
+                                              "OutputPath":  ".\\src\\System.Windows.Forms.Analyzers.CodeFixes.VisualBasic\\Resources\\xlf\\"
+                                          },
                                           {
                                               "SourceFile":  ".\\src\\System.Windows.Forms.Analyzers.CSharp\\src\\Resources\\xlf\\SR.xlf",
                                               "CopyOption":  "LangIDOnName",
                                               "OutputPath":  ".\\src\\System.Windows.Forms.Analyzers.CSharp\\src\\Resources\\xlf\\"
                                           },
+                                          {
+                                              "SourceFile":  ".\\src\\System.Windows.Forms.Analyzers.VisualBasic\\src\\Resources\\xlf\\SR.xlf",
+                                              "CopyOption":  "LangIDOnName",
+                                              "OutputPath":  ".\\src\\System.Windows.Forms.Analyzers.VisualBasic\\src\\Resources\\xlf\\"
+                                          },
                                           {
                                               "SourceFile":  ".\\src\\System.Windows.Forms.Design\\src\\Resources\\System\\ComponentModel\\Design\\xlf\\BinaryEditor.xlf",
                                               "CopyOption":  "LangIDOnName",