fix: sidebar and theme picker bugs (UCD-180) - #51
Merged
Conversation
docs/.dates_cache.jsonl and docs/.gitattributes are generated locally by the mkdocs-document-dates git hook and don't belong in the repo.
Clicking the toggle focuses it, and focus pinned the tooltip open via shouldKeepTooltipVisible. The auto-hide timer then declined to hide it and never rescheduled, so it stayed open until focus moved elsewhere. UCD-180
.md-content__inner is a flex item that keeps resizing while the ToC or nav sidebar collapses/expands, so paragraphs re-wrap continuously for the whole 300ms transition. Capping the reading width also improves it as a fixed baseline, independent of the animation. UCD-180
All layout rules for .ds-toc-toggle-wrapper (including hiding the tooltip) lived inside the >= 60em media query. Below that breakpoint the tooltip text had no display:none and rendered as unstyled, always-visible text in the mobile page flow. UCD-180
JS repositions the button via left on every ResizeObserver tick while the sidebar collapses, and --ds-motion-transition covers all properties. Each JS update restarted a fresh 300ms interpolation on left. Chrome fires ResizeObserver on nearly every frame so this was invisible there, but Firefox/Safari batch fewer callbacks, making the button visibly lag behind the sidebar animation. UCD-180
Jonas preferred the original toggle over the segmented pill switcher introduced with the collapsible sidebars (UCD-180 review feedback). Deleting the override partial falls back to Material's stock palette.html; the palette order/icons/labels and the now-unused circle-half icon go back to their pre-pill state. sun-moon.svg was never removed by the pill design, only left unused — restored from before the pill switch existed. UCD-180
ds-giusy
requested review from
jonas-haeusler
and removed request for
jonas-haeusler
August 5, 2026 08:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan