fix(variant): preserve generated inventory fidelity - #342
Merged
mkultraWasHere merged 6 commits intoAug 12, 2026
Conversation
Retain the hardened generator behavior already on main while preserving empty directories, repointing generated inventories, and resolving default variant template paths.
mkultraWasHere
changed the title
There was a problem hiding this comment.
Pull request overview
Improves generated variant inventory fidelity and deployability.
Changes:
- Preserves
.gitkeepplaceholders. - Repoints inventory
domain_namevalues. - Resolves provider templates through variant target paths with regression tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cli/internal/variant/generator.go |
Preserves placeholders and rewrites inventory paths. |
cli/internal/variant/generator_test.go |
Tests inventory rewriting and .gitkeep preservation. |
cli/cmd/provision.go |
Resolves provider inventories from variant targets. |
cli/cmd/bootstrap_test.go |
Tests default variant provider resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dreadnode-renovate-bot
Bot
added
the
area/ad-labs
Contributor
|
TY @Ne0nd0g |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keeps generated GOAD variants self-contained and deployable while retaining the hardened variant-generator behavior already present on current
main..gitkeepplaceholders so required empty directories survive generation.domain_namein generated inventory files to the variant target directory.ResolvedVariantPaths(), including the defaultad/GOAD-variant-1target.The branch was merged with current
main. Replacement logic, full-path renaming, extensionless-file handling, overlay identity rewriting, SecureString handling, and completion markers all retain the currentmainimplementations.Type of change
Testing
go test ./...go vet ./...go build ./...domain_name, and.gitkeepregression testsThe end-to-end run confirmed transformed overlay identities, renamed identity files, variant-specific inventory values, retained
.gitkeep, and a valid completion marker.Notes
No provider infrastructure was deployed end to end.