Repository navigation
fix(persistence): isolate durable stream commits from HTTP - #246
Merged
Merged
Conversation
tangletools
approved these changes
Sep 29, 2026
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — f9e91c85
Blanket team auto-approval is intentional. The merge gates are CI and codex-p1.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-09-29T23:55:55Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Isolate streamed chat persistence in a bounded worker, behind
BRIDGE_ASYNC_DURABLE_WRITES=on(default off). Every backend on the shared chat route uses the same path.synchronous=FULL; group queued writes with per-request savepoints.Evidence
Three live bridge main threads were sampled in fsync on their sessions.sqlite-wal descriptors. The streaming path performed two FULL commits per delta. This patch addresses that measured cause.
On fixed head
f9e91c85efd75f7a5b09aeb9330e6d710b5d3d2b:Review artifacts are retained privately under
/mnt/traces/discovery-portfolio-20260928/bridge-async-review-20260929/.Boundaries and rollout
This is not deployed and no active bridge was restarted. No model spend, package publishing, or dependency changes.
Admission, retained-session controls, raw frame writes, terminal raw fsync, and span-file writes retain synchronous paths. The fixture proves streamed-WAL isolation; it does not establish fleet-wide HDD responsiveness or end-to-end native capture improvement.
Enable first on an idle canary after its jobs settle; verify admission, replay, cancellation, health, and native capture before expanding.
The configured
npm run reviewcommand was attempted but unavailable: the installed dotfiles hook runner rejects the namedreviewcommand and accepts only pre-commit/pre-push. Independent source review is recorded separately; no hook was bypassed.