Generate content in an explicitly selected language - #156
Merged
MatejFrnka merged 9 commits intoSep 18, 2026
Merged
MatejFrnka merged 9 commits into
MatejFrnka merged 9 commits into
Conversation
added 7 commits
August 31, 2026 10:02
MatejFrnka
requested changes
Sep 11, 2026
MatejFrnka
requested changes
Sep 11, 2026
MatejFrnka
requested changes
Sep 11, 2026
hranasit
force-pushed
the
feature/137-generate-content-in-an-explicitly-selected-language
branch
from
September 14, 2026 09:28
848bf20 to
8879c77
Compare
hranasit
force-pushed
the
feature/137-generate-content-in-an-explicitly-selected-language
branch
from
September 14, 2026 09:29
8879c77 to
c7f1e7f
Compare
MatejFrnka
requested changes
Sep 14, 2026
hranasit
force-pushed
the
feature/137-generate-content-in-an-explicitly-selected-language
branch
from
September 14, 2026 12:18
3693fb9 to
09165c4
Compare
MatejFrnka
approved these changes
Sep 18, 2026
| const selectedOption = getLanguageOption(options, value) | ||
| const visibleOptions = filterLanguageOptions(options, deferredQuery) | ||
| const displayLabel = loading | ||
| ? 'Loading languages...' |
Collaborator
There was a problem hiding this comment.
I would keep it here so that we can finally merge it, but I would try to avoid nested ternary operators when possible. I think it is pretty hard to read it
MatejFrnka
deleted the
feature/137-generate-content-in-an-explicitly-selected-language
branch
September 18, 2026 08:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137