Remove results table - #157
Merged
Merged
Conversation
Collaborator
|
closes #62 |
hranasit
requested changes
Sep 14, 2026
| pipeline.add_component('assignment_saver_component', assignment_saver_component) | ||
| pipeline.add_component('dmp_generator_component', dmp_generator_component) | ||
| pipeline.add_component('dmp_polisher_component', dmp_polisher_component) | ||
| pipeline.add_component('saver_component', saver_component) |
Collaborator
Author
There was a problem hiding this comment.
in service/src/ai_document_plugin_service/service/pipeline_service.py
327: await self.database.update_generation(run_id, auth.tenant_uuid, **_succeeded_update(output))|
|
||
| def upgrade() -> None: | ||
| ${upgrades if upgrades else "pass"} | ||
|
|
Collaborator
There was a problem hiding this comment.
Why do we get rid of the downgrade?
Collaborator
Author
There was a problem hiding this comment.
To me, it either adds development time trying to test that the migration can be downgraded, or we add downgrades without testing they work, which to me is worse than not having them at all.
I am in favor just removing them since I don't think they are needed and it would speed up the development time.
Collaborator
Author
There was a problem hiding this comment.
I discussed with Marek as well and noone is using this. We can safely remove it
hranasit
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #154