Skip to content

Let processor AttributeErrors surface #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bolt4243 wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −2
Open

Let processor AttributeErrors surface #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions fitparse/processors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@ def run_message_processor(self, data_message):

def _run_processor(self, processor_name, data):
try:
getattr(self, processor_name)(data)
processor = getattr(self, processor_name)
except AttributeError:
pass
return
processor(data)

def process_type_bool(self, field_data):
if field_data.value is not None:
Expand Down
17 changes: 17 additions & 0 deletions tests/test_processors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import unittest

from fitparse.processors import FitFileDataProcessor


class ProcessorErrorHandlingTestCase(unittest.TestCase):
def test_processor_attribute_error_is_not_silently_ignored(self):
class RaisingProcessor(FitFileDataProcessor):
def process_field_test(self, field_data):
raise AttributeError("processor failure")

with self.assertRaisesRegex(AttributeError, "processor failure"):
RaisingProcessor()._run_processor("process_field_test", object())


if __name__ == "__main__":
unittest.main()