Skip to content

Escape filenames in GPX output - #155

Open
Bolt4243 wants to merge 1 commit into
dtcooper:masterfrom
Bolt4243:fix/escape-gpx-filename
Open

Bolt4243 wants to merge 1 commit into
dtcooper:masterfrom
Bolt4243:fix/escape-gpx-filename

Conversation

@Bolt4243

Copy link
Copy Markdown

GPX output inserts the input filename directly into the metadata and track name. A valid filename such as morning & afternoon.fit therefore produces malformed XML.

Escape the filename as XML text before writing either element. The regression parses a name containing both an ampersand and angle brackets, then checks that both elements retain the original text.

Tests: full unittest suite, workflow flake8 checks, and coverage run with 86% total coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants