Skip to content

Let completed FIT files be parsed again #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bolt4243 wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −0
Open

Let completed FIT files be parsed again #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions fitparse/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,8 @@ def messages(self):
return list(self.get_messages())

def parse(self):
if self._complete:
return
while self._parse_message():
pass

Expand Down
17 changes: 17 additions & 0 deletions tests/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,23 @@ def testfile(filename):


class FitFileTestCase(unittest.TestCase):
def test_parse_can_be_called_after_parsing_completes(self):
fit_file = FitFile(testfile('activity-settings.fit'))

fit_file.parse()
messages = fit_file.messages
fit_file.parse()

self.assertEqual(messages, fit_file.messages)

def test_parse_can_be_called_after_messages_property_completes_parsing(self):
fit_file = FitFile(testfile('activity-settings.fit'))

messages = fit_file.messages
fit_file.parse()

self.assertEqual(messages, fit_file.messages)


def test_basic_file_with_one_record(self, endian='<'):
f = FitFile(generate_fitfile(endian=endian))
Expand Down