Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fitparse/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,8 @@ class DataProcessorMixin:
"""Add data processing to the FitFileDecoder"""

def __init__(self, *args, **kwargs):
self._processor = kwargs.pop("data_processor", None) or FitFileDataProcessor()
processor = kwargs.pop("data_processor", None)
self._processor = FitFileDataProcessor() if processor is None else processor
super().__init__(*args, **kwargs)

def _parse_data_message(self, header):
Expand Down
18 changes: 17 additions & 1 deletion tests/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import warnings

from fitparse import FitFile
from fitparse.processors import UTC_REFERENCE, StandardUnitsDataProcessor
from fitparse.processors import FitFileDataProcessor, UTC_REFERENCE, StandardUnitsDataProcessor
from fitparse.records import BASE_TYPES, Crc
from fitparse.utils import FitEOFError, FitCRCError, FitHeaderError, FitParseError

Expand Down Expand Up @@ -74,6 +74,22 @@ def testfile(filename):


class FitFileTestCase(unittest.TestCase):
def test_uses_falsey_custom_data_processor(self):
class FalseyProcessor(FitFileDataProcessor):
def __init__(self):
self.called = False

def __bool__(self):
return False

def run_message_processor(self, data_message):
self.called = True

processor = FalseyProcessor()
FitFile(testfile('activity-settings.fit'), data_processor=processor).parse()

self.assertTrue(processor.called)


def test_basic_file_with_one_record(self, endian='<'):
f = FitFile(generate_fitfile(endian=endian))
Expand Down