Skip to content

Give tolerated developer fields stable names #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bolt4243 wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −0
Open

Give tolerated developer fields stable names #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions fitparse/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ def _append_dev_field_description(self, dev_data_index, field_def_num, type=BASE
)
self._append_dev_data_id(dev_data_index)

if name is None:
name = "unnamed_dev_field_%s" % field_def_num
self.dev_types[dev_data_index]["fields"][field_def_num] = DevField(
dev_data_index=dev_data_index,
def_num=field_def_num,
Expand Down
12 changes: 12 additions & 0 deletions tests/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import csv
import datetime
import io
import os
from struct import pack
import warnings
Expand Down Expand Up @@ -74,6 +75,17 @@ def testfile(filename):


class FitFileTestCase(unittest.TestCase):
def test_tolerant_missing_developer_field_can_be_iterated(self):
definition = b'\x60\x00\x00' + pack('<HB', 0, 1) + bytes([0, 1, 0, 1, 0, 1, 0])
data = bytes([0, 4, 7])
header = pack('<2BHI4s', 14, 16, 152, len(definition + data), b'.FIT') + b'\x00\x00'

with warnings.catch_warnings():
warnings.simplefilter('ignore')
message = FitFile(io.BytesIO(header + definition + data), check_crc=False,
check_developer_data=False).messages[0]
self.assertEqual(2, len(list(message)))


def test_basic_file_with_one_record(self, endian='<'):
f = FitFile(generate_fitfile(endian=endian))
Expand Down