v1.0.52 update causing constant recompilation #270

Activity

1. Turbo87 commented on Dec 28, 2023

   

   Turbo87

   on Dec 28, 2023

   Author

   More actions

   It looks like anyhow v1.0.77 is causing similar issues
2. dtolnay commented on Dec 28, 2023

   

   dtolnay

   on Dec 28, 2023

   Last edited by dtolnay

   Owner

   More actions

   How can I reproduce this? I ran cargo check --workspace in rust-lang/crates.io twice and nothing got recompiled, at rust-lang/crates.io@95236c5 which is before the 2 revert commits.
3. Turbo87 commented on Dec 28, 2023

   

   Turbo87

   on Dec 28, 2023

   Author

   More actions

   hmm, I noticed it while running tests from within IntelliJ. I'll try and reproduce it on the command line once I'm back on the computer tomorrow.
4. Turbo87 commented on Dec 29, 2023

   

   Turbo87

   on Dec 29, 2023

   Author

   More actions

   looks like IntelliJ is more or less at fault here... when running the test suite inside of IntelliJ it is first compiling the test code via:

   cargo test --color=always --no-run --package crates_io --lib rate_limiter::tests
   

   and then running the tests with:

   cargo test --color=always --package crates_io --lib rate_limiter::tests --no-fail-fast -- --format=json -Z unstable-options --show-output
   

   if I try to run the latter on the CLI outside of IntelliJ I get:

   error: the option `Z` is only accepted on the nightly compiler
   error: test failed, to rerun pass `-p crates_io --lib`
   error: 1 target failed:
       `-p crates_io --lib`
   

   so I guess IntelliJ might be using RUSTC_BOOTSTRAP to enable usage of -Z unstable-options on the stable compiler 🙈
5. Turbo87 commented on Dec 29, 2023

   

   Turbo87

   on Dec 29, 2023

   Author

   More actions

   https://youtrack.jetbrains.com/issue/RUST-13133/RUSTCBOOTSTRAP1-is-passed-to-test-configuration seems to confirm my suspicion :-/
6. dtolnay commented on Dec 29, 2023

   

   dtolnay

   on Dec 29, 2023

   Owner

   More actions

   Good catch. I commented on the RustRover issue tracker with my suggested fix.

   👍React with 👍2Reacted by Tobias Bieniek and JungChul Shin
7. dtolnay

   closed this as completedon Dec 29, 2023