Skip to content

Fix native input stop button bug#8907

Open
joshliebe wants to merge 1 commit into
developfrom
feature/josh/fix-stop-button-bug
Open

Fix native input stop button bug#8907
joshliebe wants to merge 1 commit into
developfrom
feature/josh/fix-stop-button-bug

Conversation

@joshliebe

@joshliebe joshliebe commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1200204095367872/task/1215778085975943?focus=true
Tech Design URL (if applicable):

Description

  • Hides the stop button in the native input in browser mode

Steps to test this PR

  • Type a prompt (e.g. “generate a long essay about ducks”)
  • While it is still generating, go back
  • Verify that the stop button is not visible in the browser native input

Note

Low Risk
Small UI visibility change in one ViewModel with dedicated tests; no auth, data, or API changes.

Overview
Fixes the native input stop streaming control appearing when it should not: visibility now requires active chat streaming and a non-browser InputContext (DUCK_AI or DUCK_AI_CONTEXTUAL), so browser/search native input no longer shows stop while a streaming flag may still be set.

Adds StopStreamingViewModelTest covering Duck AI visibility, suppression in BROWSER while streaming, non-streaming cases, and hiding when context switches to browser mid-stream.

Reviewed by Cursor Bugbot for commit 4d8d361. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants