Conversation
Contributor
Build Branch
Static preview entry points
QR codes (mobile preview)
Integration commandsnpm (Android / Extension): Swift Package Manager (Apple): .package(url: "https://github.com/duckduckgo/content-scope-scripts.git", branch: "pr-releases/fix/captcha-solve-reads-native-profile")git submodule (Windows): git -C submodules/content-scope-scripts fetch origin pr-releases/fix/captcha-solve-reads-native-profile
git -C submodules/content-scope-scripts checkout origin/pr-releases/fix/captcha-solve-reads-native-profilePin to exact commitnpm (Android / Extension): Swift Package Manager (Apple): .package(url: "https://github.com/duckduckgo/content-scope-scripts.git", revision: "4264d0b20e0eaafad6f30bb8592513f6fcca68a6")git submodule (Windows): git -C submodules/content-scope-scripts fetch origin pr-releases/fix/captcha-solve-reads-native-profile
git -C submodules/content-scope-scripts checkout 4264d0b20e0eaafad6f30bb8592513f6fcca68a6 |
Contributor
[Beta] Generated file diffTime updated: Mon, 07 Sep 2026 10:59:07 GMT Android
File has changed AppleFile has changed IntegrationFile has changed WindowsFile has changed |
Contributor
|
This PR requires a manual review and approval from a member of one of the following teams:
|
madblex
force-pushed
the
fix/captcha-solve-reads-native-profile
branch
from
September 6, 2026 11:49
2ba1527 to
baf4707
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Web Compatibility Assessment
| File | Lines | Severity | Finding |
|---|---|---|---|
injected/src/features/broker-protection/captcha-services/captcha.service.js |
72–178 | info | Broker-protection captcha logic runs only during native-driven PIR automation, not on arbitrary third-party pages. No browser API overrides, prototype patches, or general DOM timing changes — no general web-compat surface. |
injected/src/features/broker-protection/captcha-services/captcha.service.js |
137–141 | info | Profile-scoped solve guard is preserved (action.parent && !userData → error). This prevents solving the first widget on a multi-record page, which would remove a stranger's record — the critical compat/safety invariant from the PR description. |
injected/integration-test/broker-protection-tests/broker-protection-captcha.spec.js |
161–169 | info | Replaces the "held profile after page load" scenario with a direct "no profile on solve" test. Aligns with removing module-level state; no web-compat regression. |
injected/integration-test/page-objects/broker-protection.js |
307–309 | info | Test helper now returns only response[0] instead of matching by actionID. Test-only; acceptable for sequential flows but would not catch out-of-order multi-action completions. |
Security Assessment
| File | Lines | Severity | Finding |
|---|---|---|---|
injected/src/features/broker-protection/captcha-services/captcha.service.js |
(removed pendingCaptchaContext) |
info | Removing module-level pendingCaptchaContext is a security improvement: eliminates stale profile/token retention across navigations, failed solves, and retries. Client now supplies profile and token explicitly on each solveCaptcha, tightening the trust boundary. |
injected/src/features/broker-protection/captcha-services/captcha.service.js |
137–138 | info | Profile scoping error path retained. Prevents captcha token injection into the wrong DOM subtree when multiple user records exist on a broker page. |
injected/src/features/broker-protection/captcha-services/captcha.service.js |
160–165 | warning | The explicit no token available to solve the captcha guard was removed. A null/undefined token now flows into injectToken, which coerces to an empty input value and may return success with an empty token instead of a clear error. Low exploitability (native-controlled input), but weaker fail-closed behavior. |
| (all changed files) | — | info | No changes to messaging transports, nativeData handling, captured globals, message-bridge checks, or postMessage usage. |
Risk Level
Low Risk — Broker-protection captcha state-management refactor only; no API shims, messaging, or captured-globals changes; profile scoping guard preserved.
Recommendations
- (warning) Consider restoring an explicit
if (!token)early return insolveCaptchafor clearer fail-closed behavior and better native-client diagnostics. - (info) Honor the PR's merge gate: ship only after Apple/Android clients send
userProfilewith every scopedsolveCaptcha, or all scoped solves will fail with "no profile available". - (info) Optionally add an integration test for a missing/empty
tokenonsolveCaptchato lock in expected error behavior.
Sent by Cursor Automation: Web compat and sec
| } | ||
|
|
||
| const callback = captchaSolveProvider.getSolveCallback(captchaContainer, captchaToken); | ||
| const callback = captchaSolveProvider.getSolveCallback(captchaContainer, token); |
Contributor
There was a problem hiding this comment.
Security (warning): The previous if (!captchaToken) return createError('no token available to solve the captcha') guard was removed along with pendingCaptchaContext. A missing token now reaches injectToken / getSolveCallback, which may coerce null to an empty input value rather than failing fast. Consider restoring an explicit token check for clearer, fail-closed behavior.
github-actions
Bot
added
semver-minor
…ead of a held context
madblex
force-pushed
the
fix/captcha-solve-reads-native-profile
branch
from
September 7, 2026 10:57
baf4707 to
daf1ae9
Compare
github-actions
Bot
added
semver-major
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Asana: https://app.asana.com/1/137249556945/task/1217611870578214
This PR:
getCaptchaInfoandsolveCaptcha, because Apple and Android now send it with the token and the held copy was only standing in for that.Merge this only after the Apple and Android changes that send the profile reach a release. Until then both clients send the token alone and every scoped solve would fail.