Skip to content

Deduplicate flashloan matches in NFT wash trades - #10047

Merged
tomfutago merged 1 commit into
mainfrom
centaur/fix-nft-wash-trades-merge-duplicates-1790511630
Sep 28, 2026
Merged

tomfutago merged 1 commit into
mainfrom
centaur/fix-nft-wash-trades-merge-duplicates-1790511630

Conversation

@jeff-dude

@jeff-dude jeff-dude commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

Description:

What & why

Deduplicate flashloan matches by unique_trade_id before joining them to NFT trades.
One NFT trade can match several flashloan rows from the same transaction.
The trade keeps its flashloan flag, and the output no longer fans out into duplicate merge keys.

Architecture

  • dbt_subprojects/hourly_spellbook/macros/_sector/nft/nft_wash_trades.sql - data critical path to nft.wash_trades; filter_5 now emits one row per trade ID.
  • Validation: PR CI passed and built all 19 chain models. Ethereum completed both full refresh and incremental MERGE; its unique_trade_id test passed. Query of the Ethereum PR CI table returned zero duplicate IDs in the last two days.
  • Needs human eyes: CI does not reuse the failed production target state; confirm the next Ethereum hourly build completes.
  • Blast radius: all 19 chain wrappers call this macro and receive the fix. The published nft.wash_trades schema and flags stay the same; duplicate flashloan matches collapse to one row.
Agent context
  • Coverage ledger: No agent review yet.
  • Reproduction context: Slack failure alert
  • CI table: dune.dune_spellbook_ci__tmp_pr10047_36318857788_1.nft_ethereum_wash_trades

@github-actions github-actions Bot added WIP work in progress dbt: hourly covers the hourly dbt subproject labels Sep 27, 2026
@jeff-dude
jeff-dude marked this pull request as ready for review September 27, 2026 13:28
@github-actions github-actions Bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Sep 27, 2026
@tomfutago
tomfutago merged commit 0535273 into main Sep 28, 2026
11 checks passed
@tomfutago
tomfutago deleted the centaur/fix-nft-wash-trades-merge-duplicates-1790511630 branch September 28, 2026 07:41
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dbt: hourly covers the hourly dbt subproject ready-for-review this PR development is complete, please review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants