Topology utils - #275
Merged
Merged
Topology utils#275
Conversation
mahdiehmalekian
force-pushed
the
topology_utils
branch
from
June 24, 2026 01:09
d1303ed to
1da2b4c
Compare
Contributor
Author
|
@thisac Is this ready to be merged? |
randomir
reviewed
Jul 17, 2026
randomir
left a comment
randomir
left a comment
Member
There was a problem hiding this comment.
Did a quick review, it looks good, but I would like to do an in-depth review before me merge this.
The suggestions below are mostly minor, except the use of function objects as default argument values.
thisac
reviewed
Jul 20, 2026
mahdiehmalekian
force-pushed
the
topology_utils
branch
from
July 23, 2026 20:47
4c018d7 to
b7c7fb4
Compare
Contributor
Author
|
Is this ready to be merged? |
mahdiehmalekian
force-pushed
the
topology_utils
branch
from
August 7, 2026 23:59
3fa9a4f to
38ea8aa
Compare
mahdiehmalekian
force-pushed
the
topology_utils
branch
from
August 8, 2026 15:48
8a16320 to
78aec58
Compare
Contributor
Author
|
Is this ready to be merged? |
thisac
reviewed
Aug 31, 2026
Co-authored-by: Theodor Isacsson <tisacsson@dwavesys.com>
randomir
reviewed
Sep 2, 2026
randomir
left a comment
randomir
left a comment
Member
There was a problem hiding this comment.
Another automated review round (findings verified by execution against the PR head). 10 findings below: 7 correctness, 1 doc/contract, 1 efficiency, 1 reuse. Also validated as negatives: coordinate conversions round-trip correctly across several (m, t) shapes, Zephyr node/edge sets match zephyr_graph exactly, the common.py move preserves existing imports, and the added test suite passes.
Contributor
Author
Contributor
Author
thisac
approved these changes
Sep 17, 2026
thisac
left a comment
thisac
left a comment
Contributor
There was a problem hiding this comment.
A few last comments. As soon as @randomir has approved it should be good to go. Thanks for all the work on this one @mahdiehmalekian !
randomir
reviewed
Sep 18, 2026
randomir
left a comment
randomir
left a comment
Member
There was a problem hiding this comment.
The code looks very well written and polished.
I only have a few API-level suggestions.
mahdiehmalekian
force-pushed
the
topology_utils
branch
from
September 18, 2026 22:11
a7c9c07 to
66d37e9
Compare
Contributor
Author
|
Thank you for great suggestions @randomir. |
randomir
approved these changes
Sep 21, 2026
randomir
left a comment
randomir
left a comment
Member
There was a problem hiding this comment.
LGTM.
Thanks, @mahdiehmalekian!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The added files in
dwave/graphs/topologies/commonprovide blueprint classes for working with different aspects of any D-Wave topology.coord.py: Coordinate systems used for node labels.node_edge.py: Nodes and edges.planeshift.py: Displacement of nodes in the Cartesian plane.shape.py: Shape of a graph.topology.py: Constructing a topology graph whose nodes and edges are equipped with all the specific-topology-relevant functionalities.The added files in
dwave/graphs/topologies/zephyr, i.e.zcoord.py,znode_edge.py,zplaneshift.pyandzshape.py, contain the implementation of the corresponding objects for Zephyr topology. Inzephyr.pythe classZephyrhas been added that is built onTopologyblueprint indwave/graphs/topologies/common/topology.pyThe test suite for these modules is added in
tests.Note: This is an evolution of previous
zephyr_utilsPR tominorminer.