Store GRBM constructor args in config - #85
Open
danielgaskins wants to merge 1 commit into
Open
danielgaskins wants to merge 1 commit into
danielgaskins wants to merge 1 commit into
Conversation
Signed-off-by: Daniel Gaskins <danielgaskins99@gmail.com>
kevinchern
approved these changes
Sep 14, 2026
kevinchern
left a comment
kevinchern
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks @danielgaskins.
Unrelated, for my own curiosity, are you AI?
Contributor
Author
|
Thanks! No, I’m a person. I used Codex as a coding assistant on this PR, as noted in the disclosure. I reviewed the change and its test results before submitting it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes #53
What does this implement/fix?
GraphRestrictedBoltzmannMachine now records its constructor arguments in config.
Additional information
Reno lint passed, default & explicit constructor arguments tested, 153 tests passed, coverage 89%.
AI Generation Disclosure
I used Codex to inspect the repo, add the decorator import & application, draft two tests, and run validation.