docs: ShortBlockWindow is 40 blocks, not 20 - #456
Open
pucedoteth wants to merge 1 commit into
Open
pucedoteth wants to merge 1 commit into
pucedoteth wants to merge 1 commit into
Conversation
v4-chain raised ShortBlockWindow from 20 to 40 in adf3ad4c (#3226, 2025-11-25) and the docs still state the old value in three pages, so a short-term order's maximum GTB reads as half its real window. Also repoint the two pinned constants.go permalinks from 4eb219b1 to a1fb6ab4, since the old commit renders `= 20` next to prose now saying 40. Both constants are still on lines 9 and 17 there, so the anchors are unchanged, and StatefulOrderTimeWindow is still 95 days. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@pucedoteth is attempting to deploy a commit to the dYdX Trading Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShortBlockWindowhas been 40 sinceadf3ad4c(v4-chain #3226, 2025-11-25), but three docs pages still say 20. A reader sizing a short-term order'sgoodTilBlockfrom the docs gets half the real window.Current value on
main:What changed
docs/pages/concepts/trading/orders.mdxdocs/pages/concepts/onboarding-faqs/index.mdxdocs/pages/interaction/trading/index.mdxAlso repointed the two pinned
constants.gopermalinks inorders.mdxfrom4eb219b1toa1fb6ab4. The old commit rendersconst ShortBlockWindow uint32 = 20, which would have contradicted the corrected prose sitting right beside it. Both constants are still on lines 9 and 17 at the new commit, so#L9/#L17are unchanged.What I deliberately did not change
StatefulOrderTimeWindowis still correct. I checked it in the same file —95 * 24 * time.Hour— so the "95 days" in the table stands.I left "or about 30 seconds" alone. That figure depends on block time, which I could not verify against a source. It is plausibly still right: #3226's stated reason for raising the window was decreased block times, so the wall-clock duration was roughly preserved rather than doubled. But since I could only verify the block count, that is the only thing I changed. Happy to update the seconds figure if you have the current target block time.
docs/pages/nodes/resources.mdxis untouched. Its "short block window parameter adjustments" line describes thev9.5.0release that carried this change — it is a changelog entry, not a stale value.Verification
protocol/x/clob/types/constants.goata1fb6ab46038b028fae60d48bb554e8216a0695d(v4-chainmainat time of writing).adf3ad4cdiff is-const ShortBlockWindow uint32 = 20/+const ShortBlockWindow uint32 = 40. (Note that commit's message says "to 30" while the diff is 40 — the code is authoritative.)grep -rn "20 blocks" docs/returns nothing after the change.🤖 Generated with Claude Code