Verification pages now show live software versions and clearly flag known-bad comparisons#208
Merged
Merged
Conversation
AndrewSazonov
added
the
[scope] enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #208 +/- ##
===========================================
+ Coverage 90.33% 90.35% +0.01%
===========================================
Files 283 283
Lines 24207 24246 +39
Branches 2840 2847 +7
===========================================
+ Hits 21868 21907 +39
Misses 1743 1743
Partials 596 596
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every cross-engine verification page now states the exact software behind its curves — the FullProf, EasyDiffraction, and calculation-engine (cryspy or crysfml) versions — right in the plot legend and agreement table (for example
edi 0.11.0 (cryspy 2.4.1) vs FullProf 8.40), read live so they stay correct after any update.Pages that can't yet match their reference (because an engine feature isn't implemented) are now marked in the notebook itself with a short, visible reason instead of a separate hidden skip list; good pages stay regression checks, and a page that later starts matching deliberately fails so its "known-bad" mark gets removed rather than lingering — now tracked per individual comparison, so a known-bad engine can't hide a regression in one that does match.
A new laboratory X-ray PbSO₄ verification page is included, and a Windows-only issue in sequential fitting is fixed so the saved data folder is recorded consistently across operating systems.