Record a second X-ray wavelength (Kα₁/Kα₂) on constant-wavelength instruments#209
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #209 +/- ##
===========================================
+ Coverage 90.35% 90.38% +0.03%
===========================================
Files 283 283
Lines 24246 24276 +30
Branches 2847 2850 +3
===========================================
+ Hits 21907 21943 +36
+ Misses 1743 1738 -5
+ Partials 596 595 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constant-wavelength instruments can now record a second incident wavelength and its relative intensity — the Cu Kα₁/Kα₂ doublet typical of laboratory X-ray sources. The new wavelength and ratio settings are saved with your project and exported in standard CIF, so the information round-trips when you reload or share a project.
This is a groundwork step: the values are stored and shared but not yet used in pattern calculation, so existing single-wavelength experiments behave exactly as before. Setting only a partial pair (a ratio with no second wavelength) is reported as a clear error rather than being silently ignored.