Add X-ray polarization and monochromator optics for constant-wavelength powder#210
Merged
Conversation
Static inspection found lower-level CrysFML Lorentz routines that accept cthm/rkk, but the Python cw_powder_pattern_from_dict wrapper reads no dictionary keys for those values. Use the shared post-pattern multiplier for the wrapper path.
…CO verification scripts
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #210 +/- ##
===========================================
- Coverage 90.38% 90.38% -0.01%
===========================================
Files 283 284 +1
Lines 24276 24367 +91
Branches 2850 2860 +10
===========================================
+ Hits 21943 22024 +81
- Misses 1738 1742 +4
- Partials 595 601 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constant-wavelength X-ray powder experiments now expose two incident-beam optics parameters — a polarization coefficient and a pre-specimen monochromator angle — that control the Lorentz-polarization correction applied to calculated intensities. The settings appear only on X-ray powder instruments and are honored by both the CrysPy and CrysFML engines. Neutron experiments are unaffected, and existing X-ray results stay exactly the same until you set a polarization value, so nothing changes unless you opt in.